Drop liquidity orders from matched orders metric #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129
The "Matched Orders" panel in Grafana currently includes liquidity orders. If there are many liquidity orders the graph for matched orders declines significantly making it seem like our service is experiencing issues.
This can be solved by introducing a metric which only tracks how many user orders have been created. If we use this metric in the Grafana panel the "Matched Orders" graph will better reflect the user experience of the service.
Test Plan
Local test submitting 1 user order and 1 liquidity order.
New metric counting user orders:
Metric we previously in the Grafana panel
This shows that the new metrics is working and ignores liquidity orders.