Limit http solver response size #158
Conversation
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 64.90% 65.05% +0.15%
==========================================
Files 184 184
Lines 38321 38228 -93
==========================================
Hits 24871 24871
+ Misses 13450 13357 -93 |
| pub async fn response_body_with_size_limit( | ||
| response: &mut Response, | ||
| limit: usize, | ||
| ) -> Result<Vec<u8>> { | ||
| let mut bytes = Vec::new(); |
There was a problem hiding this comment.
I think it would make sense to offer a high performance API which allows you to pass in the buffer to avoid copying the data out of the function.
Then response_body_with_size_limit() could be a simple wrapper function around that more performant API. I believe if response_body_with_size_limit() is tagged with #[inline] we should have a simple API while still avoiding unnecessary copies.
There was a problem hiding this comment.
There is no copying going on when returning the data out of the function. The data lives on the heap and Vec stores a pointer to it and the size so it's like returning two integers. For high performance passing in the buffer would still be advantageous because it allows you to reuse the allocation in the future but I don't want to make this more complicated before specifically wanting to use that.
There was a problem hiding this comment.
Yeah, of course. You're right. 🤦♂️
It's all good then. 👍
Part of #151 .
A large response could exhaust our memory. We protect against this by limiting the size of the response to 10 MB.
Test Plan
new unit test