Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add univ3-router solver #153

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Add univ3-router solver #153

merged 3 commits into from
Apr 19, 2022

Conversation

vkgnosis
Copy link
Contributor

Next step is to integrate this with the command line arguments.

Test Plan

Manually ran the ignored test

@vkgnosis vkgnosis requested a review from a team as a code owner April 14, 2022 12:40
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #153 (f37a6e2) into main (60a29b9) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

❗ Current head f37a6e2 differs from pull request most recent head 8eecb8d. Consider uploading reports for the commit 8eecb8d to get more accurate results

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   65.10%   64.91%   -0.20%     
==========================================
  Files         183      184       +1     
  Lines       38211    38307      +96     
==========================================
- Hits        24877    24866      -11     
- Misses      13334    13441     +107     

Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall I would just capitalize the V in all the univ3 identifiers.

Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because the capitalization of the solver name is not that important.

}

fn name(&self) -> &'static str {
"Univ3Router"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Missed one lowercase "v3"

@vkgnosis vkgnosis enabled auto-merge (squash) April 19, 2022 08:09
@vkgnosis vkgnosis merged commit cda5e36 into main Apr 19, 2022
@vkgnosis vkgnosis deleted the univ3-router-solver branch April 19, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants