-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add univ3-router solver #153
Conversation
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 65.10% 64.91% -0.20%
==========================================
Files 183 184 +1
Lines 38211 38307 +96
==========================================
- Hits 24877 24866 -11
- Misses 13334 13441 +107 |
0195416
to
3a2b060
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall I would just capitalize the V
in all the univ3
identifiers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because the capitalization of the solver name is not that important.
} | ||
|
||
fn name(&self) -> &'static str { | ||
"Univ3Router" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Missed one lowercase "v3"
f37a6e2
to
8eecb8d
Compare
Next step is to integrate this with the command line arguments.
Test Plan
Manually ran the ignored test