Filter out partially fillable orders which have been filled completely #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkgnosis
approved these changes
Apr 7, 2022
nlordell
approved these changes
Apr 7, 2022
MartinquaXD
force-pushed
the
fix-zero-amounts-partially-fillabe-orders
branch
from
2fc25c9
to
64b803d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136
Sell and buy amounts for partially fillable orders get scaled according to how much they have been filled already.
After the orders have been filled they are useless and can even cause alerts in our solvers. This is because the solvers expect orders to have a non zero buy and sell amount.
To avoid that problem we simply consider orders which with a 0
max_transfer_out_amountas unsolvable.Test Plan
Updated existing tests
Added new test validating that filled partially fillable orders and normal orders with 0 amounts get filtered out.