Skip to content

Fixes #736#784

Closed
abe545 wants to merge 5 commits intocoverlet-coverage:masterfrom
namely:issue_736
Closed

Fixes #736#784
abe545 wants to merge 5 commits intocoverlet-coverage:masterfrom
namely:issue_736

Conversation

@abe545
Copy link

@abe545 abe545 commented Mar 31, 2020

Fixes issue where a hits file being written on process exit prevents the hits file from being read to generate coverage, as reported in #736 and discussed in #754

@MarcoRossignoli MarcoRossignoli added * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) driver-collectors Issue related to collectors driver labels Mar 31, 2020
@MarcoRossignoli
Copy link
Collaborator

We're next release so we don't merge this now, I've got a similar simpler fix ready on my branch master...MarcoRossignoli:fix_736, but I need to understand how to fix that test(we expect correct counting on .NET Framework)

@abe545
Copy link
Author

abe545 commented Mar 31, 2020

We're next release so we don't merge this now, I've got a similar simpler fix ready on my branch master...MarcoRossignoli:fix_736, but I need to understand how to fix that test(we expect correct counting on .NET Framework)

I'll close this then. Sorry, I thought this would make your life easier 😄

@abe545 abe545 closed this Mar 31, 2020
@MarcoRossignoli
Copy link
Collaborator

You support have been fundamental!
You did enough thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

driver-collectors Issue related to collectors driver * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants