fix(atomic): remove aria-label from results per page toolbar for accessibility #6939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
requested review from
Copilot,
fbeaudoincoveo,
lavoiesl and
y-lakhdar
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant ARIA labeling from the results-per-page component to improve accessibility for assistive technology users. The component previously had both a toolbar container and a radiogroup with the same label, causing screen readers to announce the label twice when focusing on the first radio button.
Key change:
- Removed
role="toolbar"andaria-labelattributes from the outer container div
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fbeaudoincoveo
approved these changes
Jan 12, 2026
y-lakhdar
approved these changes
Jan 12, 2026
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The double container (toolbar+radiogroup) cause AT to announce both when we focus in the first focusable element (radio element), which is noisy and redundant
KIT-5394