Skip to content

chore(atomic): migrate atomic-insight-history-toggle to Lit #6849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Copilot wants to merge 11 commits into
base: main
Choose a base branch
from
Open

chore(atomic): migrate atomic-insight-history-toggle to Lit #6849

Copilot wants to merge 11 commits into from

Conversation

Copy link
Contributor

Copilot AI commented Dec 19, 2025 •
edited by alexprudhomme
Loading

✅ Checklist

  • 🧪 The component is unit tested
  • 🧪 The component includes E2E tests
  • 🗑️ Old Cypress tests exclusive to the component are removed
  • 📖 The component is documented in storybook with an .mdx file
  • ♿ The component complies with the Web Content Accessibility Guidelines.
  • 🌐 All strings intended for humans or assistive technology must be localized with i18n.
  • 📦 The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
  • 🎨 CSS parts are documented still accessible.
  • 🦥 Slotted Content, public methods and properties are documented
  • 🔄 The component outputs the same Angular output as before with Stencil
  • 🏷️ The component declares the component type in the HTMLElementTagNameMap

https://coveord.atlassian.net/browse/KIT-4875

Copilot AI changed the title [WIP] Migrate atomic-insight-history-toggle component to Lit feat(atomic): migrate atomic-insight-history-toggle to Lit Dec 19, 2025
Copilot AI requested a review from alexprudhomme December 19, 2025 16:32
@alexprudhomme alexprudhomme changed the title feat(atomic): migrate atomic-insight-history-toggle to Lit chore(atomic): migrate atomic-insight-history-toggle to Lit Dec 19, 2025
@alexprudhomme alexprudhomme marked this pull request as ready for review December 30, 2025 16:12
@alexprudhomme alexprudhomme requested review from a team as code owners December 30, 2025 16:12
Copilot AI reviewed Dec 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the atomic-insight-history-toggle component from Stencil to Lit, replacing the legacy TSX implementation with a modern TypeScript-based Lit component. The component is a simple button toggle for displaying history panels within the Insight interface.

Key changes:

  • Converted component from Stencil (.tsx) to Lit (.ts) with proper decorators and patterns
  • Added comprehensive unit tests using Vitest browser mode (142 test cases)
  • Added E2E tests using Playwright with page object pattern
  • Created Storybook documentation with stories and MDX file

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
atomic-insight-history-toggle.ts New Lit component implementation with @customElement, @property decorators, and withTailwindStyles
atomic-insight-history-toggle.tsx Removed legacy Stencil component implementation
atomic-insight-history-toggle.pcss Removed PostCSS stylesheet (no longer needed with Tailwind)
atomic-insight-history-toggle.spec.ts New comprehensive unit tests covering rendering, properties, callbacks, and accessibility
atomic-insight-history-toggle.new.stories.tsx Storybook stories with Default and WithTooltip variants
atomic-insight-history-toggle.mdx Component documentation with usage examples
e2e/atomic-insight-history-toggle.e2e.ts E2E tests for visibility and tooltip behavior
e2e/fixture.ts Playwright fixture setup for E2E tests
e2e/page-object.ts Page object pattern for E2E test interactions
index.ts Added export for the new Lit component
lazy-index.ts Added lazy loading configuration for the component
custom-element-tags.ts Registered the component tag for Lit
components.d.ts Removed Stencil auto-generated type definitions
atomic-react/.../components.ts Added React wrapper exports for both search and commerce packages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexprudhomme alexprudhomme added cross-team This PR is a collaboration between multiple teams high-confidence The author of the PR author has high confidence that it is correct. It should be ready to merge. labels Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@louis-bompart louis-bompart louis-bompart approved these changes

@alexprudhomme alexprudhomme Awaiting requested review from alexprudhomme

@lavoiesl lavoiesl Awaiting requested review from lavoiesl lavoiesl is a code owner automatically assigned from coveo/dxui

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dxui

At least 1 approving review is required to merge this pull request.

Assignees

@alexprudhomme alexprudhomme

Copilot code review Copilot

Labels

chromatic Opt-in w/ Chromatic cross-team This PR is a collaboration between multiple teams high-confidence The author of the PR author has high confidence that it is correct. It should be ready to merge. new-lit-component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@louis-bompart @alexprudhomme