chore(atomic): add script / CI job to validate light DOM styles in Lit components #6807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a static analysis script and CI job to detect invalid :host CSS selectors in Lit components that use Light DOM (no Shadow DOM). The validation prevents a subtle bug where :host selectors in Light DOM components cause style leakage or misapplication since there's no shadow boundary.
Key changes:
- New validation script that recursively analyzes component files and imported styles for
:hostselectors in Light DOM components - CI workflow integration to run validation on every build
- npm script entry for local validation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/atomic/scripts/check-light-dom-host-selectors.mjs | New validation script that detects :host selectors in LightDomMixin and ItemSectionMixin components, including imported styles |
| packages/atomic/package.json | Adds validate:light-dom-styles npm script to run the validation |
| .github/workflows/ci.yml | Adds validate-light-dom-styles CI job that runs after build step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fbeaudoincoveo
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
lavoiesl
approved these changes
Dec 15, 2025
alexprudhomme
approved these changes
Dec 16, 2025
3 tasks
Contributor
|
@fbeaudoincoveo I've opened a new pull request, #6811, to work on those changes. Once the pull request is ready, I'll request review from you. |
3 tasks
Contributor
|
@fbeaudoincoveo I've opened a new pull request, #6812, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: fbeaudoincoveo <[email protected]>
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
…ts CI job (#6812) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: fbeaudoincoveo <[email protected]>
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-5334
#6806