fix(atomic): When a citation title is null or undefined, there's a unhandled exception #6801
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
SimonMilord
reviewed
Dec 12, 2025
Contributor
SimonMilord
left a comment
SimonMilord
left a comment
There was a problem hiding this comment.
looks fine but you sure we can't just mock a citation object with title=null and spy on an error being thrown?
Were you able to reproduce it and test the fix manually?
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFINT-6544
When the citation title is
nullorundefined, we try to call.trim()on it and it throws an exception preventing the correct rendering of the generated answer.I unfortunately don't really know where we should add tests for this?