-
Notifications
You must be signed in to change notification settings - Fork 39
feat(headless): implement events for spotlight content for commerce COMHUB2-1314 #6791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tooni
wants to merge
21
commits into
main
Choose a base branch
from
COMHUB2-1314
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMHUB2-1314
This is a follow-up to #6646, which made it so that Spotlight Content can be returned in the lists of results for listings, alongside products. Spotlight Content is arbitrary extra info that merchandisers want to set up and show.
Now, we need to emit events when the Spotlight Content is clicked. The design of the event comes from this document. It re-uses the
itemClickevent. I've implemented it by copying the similar code for product click events. Let me know if it looks alright.I've also updated the
headless/commerce-reactsamples to show Spotlight Content and emit events for it when clicked. Here is a screenshot showing Spotlight Content amongst the products on the left, and an emitted click event on the rightAnd here is a Spotlight Content click event later appearing in the event browser in the Admin Console, under Data Health