-
Notifications
You must be signed in to change notification settings - Fork 39
fix(atomic): race condition in atomic-tab-manager attribute reading during initialization #6774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ef4eb68
Initial plan
Copilot bf5ba89
Fix race condition in atomic-tab-manager by adding nullish coalescing…
Copilot 919e380
Refactor test: remove describe wrapper, inline comments, and force un…
Copilot 403187f
Fix test: clear mock calls before re-initializing to properly test ra…
Copilot 9543735
Fix test: override expression property before initialization and capt…
Copilot 8d311f3
Fix test: manually control fixture and setBindings to override proper…
Copilot 878352e
Merge branch 'main' into copilot/fix-schema-validation-bug
fbeaudoincoveo 885dd67
Fix failing test
fbeaudoincoveo 2c6d72a
Merge branch 'main' into copilot/fix-schema-validation-bug
fbeaudoincoveo 70c2e98
Use ChildrenUpdateCompleteMixin instead of falling back undefined ato…
fbeaudoincoveo 14bdee1
Better fix
fbeaudoincoveo e01197c
Use getAttribute for name and label, store all attributes in variables
Copilot aa64d2f
Remove unnecessary fallback operators for required name and label att…
Copilot 04b48a2
Merge branch 'main' into copilot/fix-schema-validation-bug
fbeaudoincoveo 8bebe34
Merge branch 'main' into copilot/fix-schema-validation-bug
fbeaudoincoveo 8d0330c
Add fallback operators for name and label to fix TypeScript compilation
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.