Skip to content

Add Node.js 24 (Krypton LTS) support and update CI #6756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
louis-bompart merged 6 commits into from
Dec 19, 2025
Merged

Add Node.js 24 (Krypton LTS) support and update CI #6756

louis-bompart merged 6 commits into from
Dec 19, 2025

Conversation

Copy link
Contributor

Copilot AI commented Dec 9, 2025 •
edited
Loading

Users installing @coveo/headless or @coveo/bueno on Node 24 receive npm warnings about unsupported engine versions. This PR extends engine compatibility to include Node 24 Krypton LTS and updates the CI to build and test with Node 24.

Changes

Updated engines.node field in all published packages and samples:

"engines": {
- "node": "^20.9.0 || ^22.11.0"
+ "node": "^20.9.0 || ^22.11.0 || ^24.11.0"
}

Updated .nvmrc for CI builds:

- 22.17.1
+ 24.11.1

Packages updated:

  • Main packages: @coveo/bueno, @coveo/headless, @coveo/headless-react, @coveo/atomic, @coveo/atomic-react, @coveo/atomic-angular, @coveo/atomic-hosted-page, @coveo/auth, @coveo/quantic, @coveo/shopify
  • CLI/Create packages: @coveo/create-atomic, @coveo/create-atomic-component, @coveo/create-atomic-component-project, @coveo/create-atomic-result-component, @coveo/create-atomic-rollup-plugin
  • Root package.json and samples

Following the established pattern of supporting LTS versions from their first release. Node 24.11.0 is the first LTS release of Krypton.

Testing

  • ✅ Build test: Successfully built @coveo/bueno package
  • ✅ Lint check: All linting checks passed (3764 files checked)
  • ✅ Pre-commit hooks: Ran successfully with no issues
  • ✅ CI will now build and test with Node 24.11.1
Original prompt

This section details on the original issue you should resolve

<issue_title>[Enhancement]: Add support Node 24</issue_title>
<issue_description>### Which product are you using?

Headless

product version

3.27.2

bug description

When using coveo/headless or coveo/bueno and running npm install there comes a warning that node24 is not supported:

Image

Steps to reproduce

use coveo/headless or coveo/bueno and run npm install.

Relevant log output

npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@coveo/[email protected]',
npm warn EBADENGINE   required: { node: '^20.9.0 || ^22.11.0' },
npm warn EBADENGINE   current: { node: 'v24.3.0', npm: '11.4.2' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@coveo/[email protected]',
npm warn EBADENGINE   required: { node: '^20.9.0 || ^22.11.0' },
npm warn EBADENGINE   current: { node: 'v24.3.0', npm: '11.4.2' }
npm warn EBADENGINE }
```</issue_description>

<agent_instructions>Try to naively bump everything everywhere</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
<comment_new><author>@louis-bompart</author><body>
Hi @Lionhunt3r , while we do not expect errors at build or runtime with Node 24, we are not actively testing or supporting it.
We aim to do so shortly after Node 24 becomes the Active LTS later this year.
Until then, the warnings you are seeing are to be expected.

I'll leave the issue open so that we can "close it" when we do ship support for Node 24</body></comment_new>
<comment_new><author>@louis-bompart</author><body>
Internal tracking [KIT-5041](https://coveord.atlassian.net/browse/KIT-5041).

This is scheduled for investigation in CY25Q4.

Official support for Node 24 will be restricted to Node 24 'Krypton' (i.e. version pre-dating the LTS release will not be supported).

Krypton is due for LTS on October 28th [^1]

[^1]: [Node Release Schedule](https://github.com/nodejs/Release/blob/main/schedule.json#L134-L140)

[KIT-5041]: https://coveord.atlassian.net/browse/KIT-5041?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ</body></comment_new>
</comments>

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add support for Node 24 in coveo packages Add Node.js 24 (Krypton LTS) support Dec 9, 2025
Copilot AI requested a review from louis-bompart December 9, 2025 19:36
@louis-bompart
Copy link
Collaborator

louis-bompart commented Dec 9, 2025

@copilot Bump the nodeJS in the CI to Kyrpton too to check if it works

Copy link
Contributor Author

Copilot AI commented Dec 9, 2025

@copilot Bump the nodeJS in the CI to Kyrpton too to check if it works

Updated .nvmrc to Node 24.11.1 (Krypton LTS) and corrected all package.json files to use ^24.11.0 (the actual first LTS version, not ^24.12.0). CI will now build and test with Node 24. Commit: c609e9c

Copilot AI changed the title Add Node.js 24 (Krypton LTS) support Add Node.js 24 (Krypton LTS) support and update CI Dec 9, 2025
@louis-bompart
Copy link
Collaborator

louis-bompart commented Dec 11, 2025

@copilot check the others package in the monorepo such as auth, otherwise it won't build

Copy link
Contributor Author

Copilot AI commented Dec 11, 2025

@copilot check the others package in the monorepo such as auth, otherwise it won't build

Added Node 24 support (^24.11.0) to all public create-* packages: @coveo/create-atomic, @coveo/create-atomic-component, @coveo/create-atomic-component-project, @coveo/create-atomic-result-component, and @coveo/create-atomic-rollup-plugin. The @coveo/auth package was already updated in the previous commit. Commit: 86ecbf0

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

🔗 Scratch Orgs ready to test this PR:

@louis-bompart louis-bompart marked this pull request as ready for review December 15, 2025 21:06
@louis-bompart louis-bompart requested review from a team as code owners December 15, 2025 21:06
Copilot AI reviewed Dec 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Node.js 24 (Krypton LTS) support to all published packages and samples in the ui-kit repository. The changes address user-reported npm warnings when installing @coveo/headless and @coveo/bueno on Node 24. The PR follows the established pattern of supporting Node LTS versions starting from their first LTS release (24.11.0 for Krypton).

Key changes:

  • Updated engines.node field in all published packages, CLI tools, and samples to include ^24.11.0
  • Updated .nvmrc from 22.17.1 to 24.11.1 for CI builds and testing
  • Incidental improvement: sample project now uses workspace:* for @coveo/auth dependency

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.nvmrc Updated Node version to 24.11.1 for CI builds
package.json Added Node 24 support to root package engines (missing Node 20)
packages/bueno/package.json Added Node 24 support to published package
packages/headless/package.json Added Node 24 support to published package
packages/headless-react/package.json Added Node 24 support to published package
packages/auth/package.json Added Node 24 support to published package
packages/atomic/package.json Added Node 24 support to published package
packages/atomic-react/package.json Added Node 24 support to published package
packages/atomic-angular/package.json Added Node 24 support to published package
packages/atomic-angular/projects/atomic-angular/package.json Added Node 24 support to Angular library
packages/atomic-hosted-page/package.json Added Node 24 support to published package
packages/quantic/package.json Added Node 24 support to published package
packages/shopify/package.json Added Node 24 support to published package
packages/create-atomic/package.json Added engines field with Node 24 support to CLI package
packages/create-atomic-component/package.json Added engines field with Node 24 support to CLI package
packages/create-atomic-component-project/package.json Added engines field with Node 24 support to CLI package
packages/create-atomic-result-component/package.json Added engines field with Node 24 support to CLI package
packages/create-atomic-rollup-plugin/package.json Added engines field with Node 24 support to CLI package
samples/headless/search-react/package.json Added Node 24 support and changed @coveo/auth to workspace:*
pnpm-lock.yaml Lockfile updates reflecting dependency and deprecation changes
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@louis-bompart louis-bompart added this pull request to the merge queue Dec 19, 2025
Merged via the queue into main with commit 1ee69fa Dec 19, 2025
173 of 205 checks passed
@louis-bompart louis-bompart deleted the copilot/add-support-node-24 branch December 19, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@malaporte malaporte malaporte approved these changes

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@louis-bompart louis-bompart Awaiting requested review from louis-bompart

@jmazzah-coveo jmazzah-coveo Awaiting requested review from jmazzah-coveo jmazzah-coveo is a code owner automatically assigned from coveo/dxui

@tedre191 tedre191 Awaiting requested review from tedre191 tedre191 is a code owner automatically assigned from coveo/salesforce-integration

@mikegron mikegron Awaiting requested review from mikegron mikegron is a code owner automatically assigned from coveo/salesforce-integration

@mmitiche mmitiche Awaiting requested review from mmitiche mmitiche is a code owner automatically assigned from coveo/salesforce-integration

Assignees

@louis-bompart louis-bompart

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support Node 24

4 participants

@louis-bompart @malaporte @alexprudhomme