Skip to content

refactor: apply code review feedback to getCitationFieldsInputArray #6739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louis-bompart merged 3 commits into from
Dec 8, 2025
Merged

refactor: apply code review feedback to getCitationFieldsInputArray #6739

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4548e4
Initial plan
Copilot Dec 8, 2025
0d2d9f4
fix: address code review comments for getCitationFieldsInputArray
Copilot Dec 8, 2025
f7177a8
Update packages/atomic/src/components/search/atomic-generated-answer/…
louis-bompart Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,15 +307,16 @@ export class AtomicGeneratedAnswer implements InitializableComponent {
}

// TODO V4 (KIT-5306): Remove support for string value.
private getCitationFieldsInputArray() {
if( Array.isArray(this.fieldsToIncludeInCitations)) {
private getCitationFieldsInputArray(): string[] {
if (Array.isArray(this.fieldsToIncludeInCitations)) {
return this.fieldsToIncludeInCitations;
} else {
} else if (this.fieldsToIncludeInCitations) {
this.bindings.engine.logger.warn(
`Starting from Atomic v4, the "fields-to-include-in-citations" property will only accept an array of strings. Using a string value is now deprecated. Please update the value to be an array of strings. For example: fields-to-include-in-citations='["fieldA","fieldB"]'`
);
return (this.fieldsToIncludeInCitations ?? '')
.split(',')
return this.fieldsToIncludeInCitations.split(',');
} else {
return [];
}
}

Expand Down
Loading