chore(headless): fix internal resolution errors in node16 #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 480b5bb.
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
commented
Sep 20, 2024
Comment on lines
-7
to
+9
| "module": "ES2022", | ||
| "module": "Node16", | ||
| "target": "ES2022", | ||
| "moduleResolution": "Bundler", | ||
| "moduleResolution": "Node16", |
There was a problem hiding this comment.
The only relevant changes in this PR is here. Changing these to Node16 is required for the types to be correctly inferred by typescript. Change this value also causes all relative imports to have a .js extension. More details here https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/docs/problems/InternalResolutionError.md
There was a problem hiding this comment.
The reason this is needed is because we use tsc to generate types and not a bundler. Therefore, we have to use moduleResolution as node16 to help typescript make the right resolutions. We can't use Bundler. Esbuild doesnt support generating types so this is our only option.
There was a problem hiding this comment.
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
changed the title
alexprudhomme
requested review from
fpbrault,
louis-bompart and
fbeaudoincoveo
and removed request for
a team
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Sep 23, 2024
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
To be merged into #4442 Unit tests were failing because Jest has a hard time with ESM modules. I tried to make it work but it ended up being easier to switch to vitest altogether. The api are really really similar, it should not change how we write tests. ## Headless-react unit tests are still failing it is addressed here - > #4452 --------- Co-authored-by: Louis Bompart <[email protected]>
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
added a commit
that referenced
this pull request
Sep 24, 2024
… headless (#4442) https://coveord.atlassian.net/browse/KIT-3580 ## Unit tests are failing. This is adressed [here](https://github.com/coveo/ui-kit/pull/4449/files#diff-75f80b97846615f5b074710648b8191f74aa4f00fd1536c45bc344b284ca8e87), once all PRs are approved we will merge in here ## [Publint](https://publint.dev/) status - atomic : no errors - headless: no errors - atomic-react: no errors ## [Are the types wrong](https://arethetypeswrong.github.io/) status - atomic : errors Internal resolution in node16 (Do we need to address this ?) + cjs type warnings - headless: errors Internal resolution in node16 ([addressed here](#4445)) + cjs type warnings - atomic-react: cjs type warnings --------- Co-authored-by: Alex Prudhomme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests are failing. This is adressed here, once all PRs are approved we will merge in #4442
Publint status
Are the types wrong status