Merged
Conversation
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
louis-bompart
requested changes
Nov 22, 2022
Contributor
|
Just making sure that this branch should be merged in master first #2556 (before merging this one) We could also trying out the dep pipeline as soon as its merged |
859191c to
74dc658
Compare
btaillon-coveo
commented
Nov 25, 2022
Contributor
Author
|
Update: I'm not gonna bump private packages, since it looks like the CI didn't bump them in the first place, and it makes |
olamothe
approved these changes
Nov 25, 2022
ThibodeauJF
approved these changes
Nov 25, 2022
louis-bompart
approved these changes
Nov 25, 2022
Collaborator
louis-bompart
left a comment
There was a problem hiding this comment.
lgtm overall, tho I don't know/understand all the process because well I'm not familiar with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-2150
Divided & adapted from: #2553
We're not migrating the normal release process yet since I'm running out of time.
New prerelease process
Look at the
README.mdto know the new release process:ui-kit/README.md
Lines 57 to 81 in 49021bb
Changes in this PR
bump:version:major-prereleasescript to the rootpackage.jsonlernagives version bumps, including[skip-ci].prerelease/**branch now trigger the same CI asmaster, except:/pre\.[0-9]+$/are upgraded.prerelease/**branch now trigger the same CI asmaster, except:/pre\.[0-9]+$/are published to NPM.alphatag on NPM isn't updated.devenvironment.Other details
major/minor/patchversion, the prerelease version will be ignored. Therefor,2.0.0will already be available on the dev CDN, and will be overwritten every time we update the prerelease. Out of scope packages will also update their CDN, but in theory the files should be the same anyway.@coveo/headless@2.0.0-pre.2would exclusively be uploaded to the following in the CDN: