chore(esm): purer ESM package #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
aiheon and
GermainBergeron
and removed request for
aiheon
louis-bompart
force-pushed
the
chore/ts-esm-experimental
branch
from
d537a1a to
13c5edc
Compare
GermainBergeron
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Tested and validated with [email protected] and [email protected] which was throwing errors previously! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESM support in Node is quite recent, which can cause some hiccups sometimes.
Here, this was due to bad local imports which resulted in the need to use an experimental specifier.
The issue is that specifier is not actively developed at this time: nodejs/node#41087 (comment)
I reevaluated the need for it, and it ain't cool for users to have to specify this kind of thing, it should just work ™️.
So, I read back what I would call "The Bible of howto ESM" and followed the advice listed in here: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
Mainly, what changed:
An alpha release has been made with this code, it can be found on version 0.1.1-alpha1
For the users: just call
node ./yourScriptThatDependsOnThisPackage.mjs, no flags whatsoever, and it will work.Footnotes
https://nodejs.org/api/esm.html#import-specifiers ↩