Skip to content

feat: permanentid - replace sha256 by md5(30)+sha1(30) #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2022
Merged

feat: permanentid - replace sha256 by md5(30)+sha1(30) #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/com/coveo/pushapiclient/DocumentBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,9 @@ private void validateReservedMetadataKeyNames(String key) {

private void generatePermanentId() {
if (this.document.permanentId == null) {
this.document.permanentId = DigestUtils.sha256Hex(this.document.uri);
String md5 = DigestUtils.md5Hex(this.document.uri);
String sha1 = DigestUtils.sha1Hex(this.document.uri);
this.document.permanentId = md5.substring(0, 30) + sha1.substring(0, 30);
}
}
}
8 changes: 5 additions & 3 deletions src/test/java/com/coveo/pushapiclient/DocumentBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,11 @@ public void testWithPermanentId() {

@Test
public void testWithPermanentIdGeneration() {
assertTrue(
docBuilder = new DocumentBuilder("https://foo.com", "bar");
assertEquals(
"permanentId should be generated automatically if not set",
docBuilder.marshalJsonObject().get("permanentId").getAsString().length() > 0
"aa2e0510b66edff7f05e2b30d4f1b3a4b5481c06b69f41751c54675c5afb",
docBuilder.marshalJsonObject().get("permanentId").getAsString()
);
}

Expand Down Expand Up @@ -373,4 +375,4 @@ public void marshal() {
);
}

}
}