-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mantine, tabledaterangepicker): close datepicker when clicking back on calendar button #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
aboissinot-coveo
changed the title
UI tool 8787/fix datepicker button
fix(mantine, tabledaterangepicker): close datepicker when clicking back on calendar button
May 19, 2023
aboissinot-coveo
requested review from
a team,
GermainBergeron and
msrioux-coveo
and removed request for
a team
May 19, 2023 17:03
dmgauthier
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GG
gdostie
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In the component
TableDateRangePicker
, when clicking on the calendar button, the date picker would open fine. However, when clicking again on the same button, the date picker would stay open instead of closing.onClick
handler of the button to pass an updater function tosetOpened
instead oftrue
. That updater function receives the pending state and returns the opposite.formatedRange
=>formattedRange
)vitest
config to get rid of typings errors withreact-testing-library
matchers (based on this).Component fix
Screen.Recording.2023-05-19.at.11.37.03.AM.mov
Screen.Recording.2023-05-19.at.11.42.22.AM.mov
Typings fix
Potential Breaking Changes
None.
Acceptance Criteria