Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! The current config structure you have set up, which is two files
tsconfig.server.json
andtsconfig.client.json
, is horribly bad practice and highly annoying to work with.These files can't be really detected by vscode and probably other editors
This causes magnitude of issues, my editor was behaving very wierldy with these files, my types just weren't randomly detected. And this is not easily fixable: microsoft/vscode#12463 (comment) ms just say that this is not a good way of doing it
Adding anything relative to them is annoying. If you want to add type roots for types in the server you need to explicitly specify that they are in
src/server/types
rather than justtypes
in server tsconfigThis pr changes it to two
tsconfig.json
in server and client directories that depend on main one