Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tsconfigs structure #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MrBartusek
Copy link

Hey! The current config structure you have set up, which is two files tsconfig.server.json and tsconfig.client.json, is horribly bad practice and highly annoying to work with.

These files can't be really detected by vscode and probably other editors

image

This causes magnitude of issues, my editor was behaving very wierldy with these files, my types just weren't randomly detected. And this is not easily fixable: microsoft/vscode#12463 (comment) ms just say that this is not a good way of doing it

Adding anything relative to them is annoying. If you want to add type roots for types in the server you need to explicitly specify that they are in src/server/types rather than just types in server tsconfig

This pr changes it to two tsconfig.json in server and client directories that depend on main one

@MrBartusek
Copy link
Author

Happy second birthday PR #9 🥳

@atlc @przekwas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant