-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 4 autoref from main page and 31 from lineage-proposals #2253
Conversation
Thank you. so i can add all the milestones in the secondary page without fearing to mess things right? |
I can't really see the diff for |
Maybe for the fact i added milestones to secondary page ? |
If there's a milestone on main page, milestones on the secondary page won't influence the result. However it will take milestones from secondary pages if there's no milestone on main page. |
Not quite. The opposite is happening within some lineages within this PR. There are 5 lineages that convert his This is the same issue I discovered earlier this week with auto generating this. It's why I am changing direction. |
I believe that he shouldn't have to worry at all about milestoning issues. In fact, I think he should be encouraged to milestone every single connection; worry-free. @FedeGueli I am working on a new workflow that I hope to PR here soon. It will collect ALL lineage-milestone-issue connections and document them rather than needing to narrow it down to just one issue as with I plan on creating a supplementary file to go along with
With this supplementary file, there will be no lost information; The only way to lose information is to not milestone and label enough. |
What are they? Each autoref shall not have any prior refs in lineage_notes.txt. So such conversion won't happen. |
I was not talking about that aspect. Based on @FedeGueli 's PR and your PR, there are 5 lineages that have issues within the main repo where your PR didn't use those main repo issues, but the secondary repos issues. The reason is because the main repo hasn't had it's milestones updated in 2 days. So they aren't milestoned yet, but @FedeGueli had identified these currently non-milestoned issues. The major issue is that since autoref does not modify existing references, all of these need to be correctly identified and fixed after each autoref update. But the 5 issues are what has been identified so far. This number could go up. However, if autoref were to update existing references, then that would have it's own problems. This is why I'm focused on validation and continuously updating information now. The following have been identified within the main repo...
|
I see. In the next version I'll come up with a fix of this by checking main page milestones for lineages with secondary page refs. Assuming they eventually get their milestones on main page they eventually will be linked to their main page ref. Currently autorefs and manual refs are actually distinguishable (manual refs use “from" while autoref uses "From"), so it's not hard to detect and remove autorefs and update with new ones. So @FedeGueli feel free for milestone on the secondary page. |
Ah sorry, it was the PR from @Over-There-Is, not @FedeGueli. Maybe that led to some confusion.
This will be good,. This sounds like that autoref will be changed to overwrite existing references, right?
This isn't currently consistent within |
Thanks @aviczhl2! I had to manually resolve some conflicts, and there was a warning that I would be changing a master branch (probably yours since this still requires merging) -- so you might want to check your local master branch vs. github. I hope that doesn't create an inconvenience for you. |
Also modified the code to priortize milestones on main page.
@AngieHinrichs
If there's a milestone on both main page and sars-cov-2, it will prioritize main page now.
@ciscorucinski
Please take a look at the new code now, may be helpful.