Validate forms on submit, restyle validation messages #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevePole
reviewed
May 18, 2020
| @@ -85,7 +85,9 @@ export const AddTestToIdentifierPage: FC = () => { | |||
| }); | |||
|
|
|||
| const fieldError = (key: keyof FormFields) => | |||
| form.touched[key] && form.errors[key] ? <Text>{form.errors[key]}</Text> : null; | |||
| (form.submitCount > 0 || form.touched[key]) && form.errors[key] ? ( | |||
There was a problem hiding this comment.
Seen this logic three times now, maybe you should move to a library?
There was a problem hiding this comment.
Yup, will see if I can create a type-safe component 👍
StevePole
reviewed
May 18, 2020
| @@ -13,7 +13,11 @@ interface TestFieldsProps { | |||
|
|
|||
| export const TestFields: FC<TestFieldsProps> = ({ form, testType }) => { | |||
| const fieldError = (key: keyof TestType['resultsSchema']['properties']) => | |||
| form.touched[key] && form.errors[key] ? <Text>{form.errors[key]}</Text> : null; | |||
| (form.submitCount > 0 || form.touched[key]) && form.errors[key] ? ( | |||
StevePole
reviewed
May 18, 2020
| @@ -99,5 +99,6 @@ | |||
| "addTestToIdentifierPage.form.identifier.invalid.magicLink": "Please check the email address", | |||
| "addTestToIdentifierPage.form.identifier.invalid.estonianId": "Please check the identification code", | |||
| "addTestToIdentifierPage.button": "Add test result", | |||
| "addTestToIdentifierPage.success": "Test result for {{ identifier }} added." | |||
| "addTestToIdentifierPage.success": "Test result for {{ identifier }} added.", | |||
| "testFields.error.generic": "Please check the input" | |||
There was a problem hiding this comment.
Slightly odd phrase. Perhaps something more like "Invalid value, please try again"?
There was a problem hiding this comment.
Agreed, tried to follow the Please x phrasing of the other messages, but it ended up weird.
StevePole
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current form experience is not great, as the immediate validation messages make the rest of the form jump. In addition, the form validation messages have the body text colour and are not noticeable.
Changes
Screenshots
After
Before
(schema errors)
