Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n support #47

Merged
merged 6 commits into from
May 2, 2020
Merged

Add i18n support #47

merged 6 commits into from
May 2, 2020

Conversation

oliverviljamaa
Copy link
Contributor

@oliverviljamaa oliverviljamaa commented May 2, 2020

Closes #39.

Context

For the Estonian deployment, we'll need to internationalise and localise the app to the Estonian language 🇪🇪.

Currently, the copy is hardcoded in the components in English 🇬🇧.

Changes

  • retranslate translation library is added
  • English messages are moved from inside the components to the messages file (src/i18n/en.json)

Considerations

Left to do:

@oliverviljamaa oliverviljamaa linked an issue May 2, 2020 that may be closed by this pull request
@oliverviljamaa oliverviljamaa marked this pull request as ready for review May 2, 2020 13:17
@oliverviljamaa oliverviljamaa changed the title Add i18n support, not found page translations, and test helper Add i18n support May 2, 2020
@oliverviljamaa oliverviljamaa merged commit 8adcdf1 into master May 2, 2020
@oliverviljamaa oliverviljamaa deleted the i18n branch May 2, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization
2 participants