Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cc 3 signup personal information page #13

Open
wants to merge 54 commits into
base: main
Choose a base branch
from

Conversation

yatsky
Copy link
Contributor

@yatsky yatsky commented Oct 1, 2022

Create form fields for collecting Personal Information on the Sign Up page.

@VanderDeng
Copy link
Contributor

Using table driven may not be suitable for the current form input, the code readability is not good, and it is too complicated and difficult to maintain for other members in the future.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yatsky
Copy link
Contributor Author

yatsky commented Oct 4, 2022

Using table driven may not be suitable for the current form input, the code readability is not good, and it is too complicated and difficult to maintain for other members in the future.

Table driven logic has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants