Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cc-0031 modify ruler btn #38

Merged
merged 8 commits into from
Jun 7, 2022
Merged

feat: cc-0031 modify ruler btn #38

merged 8 commits into from
Jun 7, 2022

Conversation

stevenliu986
Copy link
Contributor

No description provided.

tatoMa
tatoMa reviewed Jun 3, 2022
View reviewed changes
Copy link
Contributor

@tatoMa tatoMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give it a try using the global CSS modifier but aimed at this specific switch thumb color changing.
image
image

tatoMa
tatoMa approved these changes Jun 5, 2022
View reviewed changes
Copy link
Contributor

@tatoMa tatoMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tatoMa
tatoMa requested changes Jun 5, 2022
View reviewed changes
src/components/EditorFooter/index.tsx Outdated Show resolved Hide resolved
tatoMa
tatoMa approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@tatoMa tatoMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If nobody uses the global CSS style, you can simply delete it.

tatoMa
tatoMa approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@tatoMa tatoMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenliu986 stevenliu986 merged commit 64c152a into main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kritomomo kritomomo kritomomo left review comments

@Fuchih Fuchih Fuchih approved these changes

@tatoMa tatoMa tatoMa approved these changes

Assignees
No one assigned
Labels
can review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenliu986 @tatoMa @Fuchih @kritomomo