Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CVE-2021-3538 related to the non-default uuid4 request_id_format option #611

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

malud
Copy link
Collaborator

@malud malud commented Oct 26, 2022

Related to a security scan we will switch the underlying package from github.com/satori/go.uuid (satori/go.uuid#73) to github.com/google/uuid.

Our default format is https://github.com/rs/xid, which maps to the common option. The user have explicitly enable uuid4 in the request_id_format attribute within the settings block.


Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch merged commit 9bcac71 into release.1.10 Oct 26, 2022
@johakoch johakoch deleted the change-uuid-pkg branch October 26, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants