Don't sort priority countries #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-studio
changed the title
|
The current behaviour is a bug that I completely missed. The intended behaviour is the one you describe. I'll do a PR to fix it, while still allowing Edit: Thanks for the report and the PR! |
|
Closing in favour of #213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #52 we shouldn't sort priority countries.
A change has been introduced in #202 to use the
sort_providedvalue instead offalse.It removes the possibility to have the normal list of countries sorted alphabetically, and the priority list sorted as provided (which imo is an intuitive expectation).
We should either use a different attribute (
sort_priority_provided) or just set it tofalseas it used to be.