Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

[monorepo] regenerate yarn.lock #390

Merged
merged 2 commits into from
Dec 27, 2018
Merged

[monorepo] regenerate yarn.lock #390

merged 2 commits into from
Dec 27, 2018

Conversation

ldct
Copy link
Member

@ldct ldct commented Dec 27, 2018

No description provided.

@ldct ldct changed the title regenerate yarn.lock [monorepo] regenerate yarn.lock Dec 27, 2018
Copy link
Contributor

@joelalejandro joelalejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A binary build for "scrypt" is apparently breaking tests.

@Alonski
Copy link
Member

Alonski commented Dec 27, 2018

@IIIIllllIIIIllllIIIIllllIIIIllllIIIIll Why did you need to regenerate the yarn.lock? This will update all dependencies as per their semver definition in package.json

If we want to update packages we should IMO be using yarn upgrade interactive

@ldct
Copy link
Member Author

ldct commented Dec 27, 2018

@Alonski I'm trying to rebase #163 which changes yarn.lock. AFAICT we pin packages and use greenkeeper enough that no direct dependencies get upgraded.

@ldct ldct dismissed joelalejandro’s stale review December 27, 2018 12:42

could not reproduce

@ldct ldct merged commit b80b355 into master Dec 27, 2018
@ldct
Copy link
Member Author

ldct commented Dec 27, 2018

there's a guess here that the intermittent unterminated ifndef errors are caused by node_gyp trying to build downloaded files when the download fails halfway phusion/node-sha3#42 (comment)

@snario snario deleted the ldct/renegerate-lock branch December 27, 2018 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants