This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
Replace ethers usage to always import from module #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snario
requested review from
mitchelljustin and
ldct
and removed request for
mitchelljustin
| myDeposit: ethers.utils.bigNumberify("1"), | ||
| peerDeposit: ethers.utils.bigNumberify("1"), | ||
| timeout: ethers.utils.bigNumberify("1"), | ||
| myDeposit: One, |
There was a problem hiding this comment.
@snario I'm not particularly sure about this one. I think it's clearer to use bigNumerify("1"), but that's just me, take it or leave it :P
snario
added a commit
that referenced
this pull request
Dec 27, 2018
…o facilitate it (#163) * wip * wip * passing tests2 * apps folder tests pass * lint * cleaner code * cleaner code * install protocol tests * set state tests * test improvements * setup protocol tests * some fixes * tests pass for all cf ops * touch ups * code cleanup * start of cleaning up proposer tests * update waffle * clean up tests for install proposer * continue to ensure tests pass * remove useless file * remove bad test * tests for all proposers * parallelize tests * rearrange deps * still wip * remove warning on yarn * some cleanups to package * considerable improvements to code quality in machine * remove 4447 json network * checkpointing stuff * commitment tests passing * mostly tested machine functionality * better testing * make explicit unused files * nice script stuff * fix tests after ethers update * updates * clean up tests to handle immutable * code cleanup * add comment * remove files that should not be here * remove files that should not be here * remove yarn clean * remove machine dependency on cf.js * minor readme touch up * fix lint * remove bold and normal in build.sh * Update packages/machine/src/models/state-channel.ts Co-Authored-By: snario <[email protected]> * Update packages/machine/src/ethereum/install.ts Co-Authored-By: snario <[email protected]> * Update packages/machine/src/models/app-instance.ts Co-Authored-By: snario <[email protected]> * move utils to module import * typo * add doc * typo * replace console.log with tests * import from ethers/* * change dependencies to devDepencies for apps package * switch to resolver map * type arbitrary state objects better * use template literals for error messages * inline Map mutations for cleaner code * abridge if statement * Delegatecall -> DelegateCall * Update packages/machine/src/ethereum/utils/free-balance.ts Co-Authored-By: snario <[email protected]> * remove unused class * Update packages/machine/src/ethereum/uninstall.ts Co-Authored-By: snario <[email protected]> * Update packages/machine/src/ethereum/uninstall.ts Co-Authored-By: snario <[email protected]> * Update packages/machine/src/ethereum/install.ts Co-Authored-By: snario <[email protected]> * symlink .soliumrc.json * use ethers module imports some more * shorten tsconfig in @apps * add --detectOpenHandles back * shorten lines in .gitignore * re-sort .soliumrc.json file * uncomment critical line in StateChannelTransaction * Update packages/contracts/contracts/libs/LibStaticCall.sol Co-Authored-By: snario <[email protected]> * better documentation of appStates mapping * better documentation of appResolutions mapping * rename _id to id in all .sol files * better docs on setState method * remove test:windows because its the same * re-version @types to 0.0.1 * rename TIMEOUT variable to ONCHAIN_CHALLENGE_TIMEOUT in a test * import Wallet in constants.ts * remove some commented out code * fresh conflict-free yarn.lock file * rename monotonicSeqNo according to Xuanjis's proposed scheme '#163 (comment)' * use ReadonlyMap not Readonly<Map * add ethereum-waffle typescript typings * remove ts-ignore * update ethers to 0.4.20 * remove unnecessary build step for @types * remove some more tsignores * remove unused imports * reintroduce script to build types * add apps to build string * better variable naming * fix @types build process * add ganache-cli to test process of machine * fix typo * undo export of cf * Add infrastructure to run ganache-cli tests in machine * Fix ordering of fields in tuple causing encoding to be incorrect * Fix incorrect block.number / finalizesAt value comparison * Add MinimumViableMultisig to the migrations (for use with proxyfactory) * Remove --reset flag on truffle migrate for contracts * Rename appState to encodedAppState on SetStateCommitment for clarity * Use encodePacked not encode for getTransactionHash on Multisig * Add encodedTerms method on AppInstance * Change default timeouts to 10 not 100 (for tests) * Update the types folder to correctly export types and enums * Update yarn.lock * Working blockchain test * rename file * Fix timeout test after value change * Switch arrow notation to function for encodeTransactions * Add missing variable usage in test.sh * more descriptive test description * Fix a linting error * add types to front of build.sh string * use relative importing in contracts as it turns out it is causing double compilation * fix an incorrect merge from earlier of master * nearly finished working merge of virtualAppAgreement test * Remove multisig.ts util file * testing rename of files to see how git treats the rename * Rename files to old names to fix git history * Add build symlink * ensure tests pass * fix some linting issues * update circleci config * dont delete .env when cleaning * imrpoved usage of exit signals for bash trap * ensure circleci runs tests correctly * update some README * Update README.md * Rename truffle.js to truffle-config.js * Replace ethers usage to always import from module (#364) * Replace all ethers utils with module imports * Fixed a few places I missed the first time * Update rollup for cf.js to include ethers.constants * Rename appCfAddress to appInstanceId (#372) * Add @firebase/app-types to devDependencies on node * fix some linting issues * Add apps back to build file * Update packages/machine/test/integration/setup-then-set-state.spec.ts Co-Authored-By: snario <[email protected]> * Revert syntax error from github suggestion * Remove duplicate code * yarn.lock * fix solium to 1.1.8 * update waffle
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Across the entire repo.