SDKQE-2411: Dotnet combination test pipeline matrix improvements #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivations: The combination pipeline does not run all the server versions when they are run, only the first version will run. Also the combination tests are always skipped and will not run unless replayed. Modifications: - Introduce a matrix for the combination tests so that all the versions will be run in parallel - Fix logic of when the combination tests will be skipped/run - Made combination test script more resilient to errors during setup that may prevent tests from running
Contributor
Author
|
FYI Here's this script being run on jenkins: http://sdk.jenkins.couchbase.com/job/dotnet/job/sdk/job/couchbase-net-scripted-build-pipeline-wip/33/ About ~2/3rds of the test failures are fixed in this patch https://review.couchbase.org/c/couchbase-net-client/+/171117 |
Contributor
jeffrymorris
left a comment
jeffrymorris
left a comment
There was a problem hiding this comment.
LGTM, but @RiPont should take as look as he has been working on Jenkins more than myself.
Jeff
avsej
force-pushed
the
master
branch
12 times, most recently
from
8a4c1d1 to
55e217f
Compare
avsej
force-pushed
the
master
branch
4 times, most recently
from
eb289ec to
4ee748c
Compare
avsej
force-pushed
the
master
branch
2 times, most recently
from
24bcbaf to
ab7ac0c
Compare
avsej
force-pushed
the
master
branch
4 times, most recently
from
a5a2f84 to
7bba9f5
Compare
avsej
force-pushed
the
master
branch
27 times, most recently
from
e6f22e5 to
44b9890
Compare
avsej
force-pushed
the
master
branch
3 times, most recently
from
f31f040 to
6c29307
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations:
The combination pipeline does not run all the server versions when
they are run, only the first version will run. Also the combination
tests are always skipped and will not run unless replayed.
Modifications:
versions will be run in parallel
setup that may prevent tests from running