Update SDK 3 FTS to further detail facets in results #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschl
reviewed
Oct 27, 2020
daschl
reviewed
Oct 27, 2020
daschl
reviewed
Oct 27, 2020
rfc/0052-sdk3-full-text-search.md
Outdated
|
|
||
| ##### Term Facet Results | ||
| ``` | ||
| class TermFacetResult implements SearchFacetResult { |
There was a problem hiding this comment.
java calls it TermSearchFacetResult
daschl
reviewed
Oct 27, 2020
rfc/0052-sdk3-full-text-search.md
Outdated
| The JSON structure of each **term range** is: | ||
|
|
||
| ``` | ||
| TermRange { |
There was a problem hiding this comment.
java calls it SearchTermRange
daschl
reviewed
Oct 27, 2020
rfc/0052-sdk3-full-text-search.md
Outdated
|
|
||
| ##### Date Range Facet Results | ||
| ``` | ||
| class DateFacetResult implements SearchFacetResult { |
There was a problem hiding this comment.
java is DateRangeSearchFacetResult (and same pattern for the others)
daschl
reviewed
Oct 27, 2020
| long other(); | ||
| List<TermFacetResult> terms(); | ||
| List<NumericRangeFacetResult> numericRanges(); | ||
| List<DateRangeFacetResult> dateRanges(); |
There was a problem hiding this comment.
the names now also need to be modified
daschl
reviewed
Oct 27, 2020
| The JSON structure of each **date range** is: | ||
|
|
||
| ``` | ||
| DateRange { |
daschl
reviewed
Oct 27, 2020
| The JSON structure of each **numeric range** is: | ||
|
|
||
| ``` | ||
| NumericRange { |
daschl
reviewed
Oct 27, 2020
| The JSON structure of each **term range** is: | ||
|
|
||
| ``` | ||
| TermFacet { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.