RFC-0078: Zone-Aware Replica Reads #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsej
force-pushed
the
0077-zone-aware-replica-reads
branch
3 times, most recently
from
4ffb771
to
bec99f8
Compare
avsej
force-pushed
the
0077-zone-aware-replica-reads
branch
2 times, most recently
from
63f2d41
to
f3c50be
Compare
avsej
force-pushed
the
0077-zone-aware-replica-reads
branch
from
f3c50be
to
7b9694f
Compare
avsej
requested review from
jeffrymorris,
chvck,
brett19,
RiPont,
dnault,
thejcfactor and
Matt-Woz
|
@programmatix I've uploaded update for transactions API. It documents |
programmatix
requested changes
May 29, 2024
programmatix
previously approved these changes
Jun 6, 2024
avsej
commented
Jun 10, 2024
brett19
reviewed
Jun 10, 2024
DemetrisChr
reviewed
Jun 17, 2024
chvck
reviewed
Jun 18, 2024
chvck
reviewed
Jun 27, 2024
dnault
reviewed
Aug 7, 2024
| ``` | ||
| enum ReadPreference { | ||
| NO_PREFERENCE, | ||
| SELECTED_SERVER_GROUP, |
There was a problem hiding this comment.
Should this be PREFERRED_SERVER_GROUP (or SERVER_GROUP) to match the name of the cluster option?
dnault
reviewed
Aug 7, 2024
| ``` | ||
| class ClusterOptions { | ||
| // ... | ||
| ClusterOptions preferredServerGroup(String serverGroupName); |
There was a problem hiding this comment.
Should we have a standard name for a corresponding connection string property?
If so, would that nudge us towards calling this just serverGroup which is ~50% easier to type? :-)
mikereiche
approved these changes
Aug 7, 2024
| options() | ||
| .timeout("20ms") | ||
| .read_preference(SELECTED_SERVER_GROUP)) | ||
| } catch DocumentUnretrievableException | DocumentNotFoundException { |
There was a problem hiding this comment.
@avsej for my understanding - I thought the replica methods would never raise DocumentNotFoundException?
programmatix
approved these changes
Aug 22, 2024
programmatix
reviewed
Sep 5, 2024
|
|
||
|  | ||
|
|
||
| ## Selected Server Group with Fallback |
There was a problem hiding this comment.
@avsej this isn't in the ReadPreference enum below - which one is correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.