RSCBC-147: Fix various issues with running unit tests against a cluster_run-based cluster #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peter-Searby
force-pushed
the
RSCBC-147
branch
2 times, most recently
from
2d09eaf to
612ec3b
Compare
Simplifies some code, and reduces repetition.
Peter-Searby
force-pushed
the
RSCBC-147
branch
2 times, most recently
from
9afdb85 to
6ca92c0
Compare
Fix test_json_block_read in tests/http.rs to use the http port, not just assume 8091.
The streaming API is being used in a non-streaming context, so it just hangs.
Peter-Searby
force-pushed
the
RSCBC-147
branch
from
6ca92c0 to
d9de74b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix all of the issues faced when using cluster_run (some of which may or may not just be caused by flakiness in the tests), but does cover the following:
/_p/<service>/proxy API, so that the mgmt port can be used for all such requests (note, this is not needed for any tests depending on any auto-discovery of ports)