- 
                Notifications
    You must be signed in to change notification settings 
- Fork 0
DOC-13306: Add documentation for indexer level scan timeout #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 
A few links to the Rebalance page are in the .html format instead of the .adoc format. Please fix those. 
- 
I'm working on smart batching but not as a part of the 8.0 release. A link to it can be added after the Morpheus release. 
Rest of the contents LGTM!
| Hi This looks good. Just to add more Sorry for missing to mention this on the MB but i think its better to also mention the rationale behind having two timeouts one at query level and one at indexer level. This timeout at indexer was introduced as index scans will consume indexer resources like memory and cpu while holding snapshots and performing range scan. For a typical index scan we don't expect indexer to run for longer than 2 minutes hence the default. Thanks | 
* DOC-5669: Add indexer settings REST API * Add index batch size for rebalance * Add the default for `defer_build` * Default timeout for indexer * Update settings * Has examples and defaults * Add description * Add example titles * Update storage mode as a composite schema * Driveby: fix default preview config * Driveby: Update composed schema templates * Driveby: Add descriptions to REST API specs for composite schemas * Driveby: update overlay for Eventing REST API * Driveby: Include description for composite schemas * Driveby: fix maximum and minimum exclusives * Build output documentation --------- Co-authored-by: tech-comm-team-couchbase <[email protected]>
* DOC-5669: Add indexer settings REST API * Add index batch size for rebalance * Add the default for `defer_build` * Default timeout for indexer * Update settings * Has examples and defaults * Add description * Add example titles * Update storage mode as a composite schema * Driveby: fix default preview config * Driveby: Update composed schema templates * Driveby: Add descriptions to REST API specs for composite schemas * Driveby: update overlay for Eventing REST API * Driveby: Include description for composite schemas * Driveby: fix maximum and minimum exclusives * Build output documentation --------- Co-authored-by: tech-comm-team-couchbase <[email protected]>
Docs issue: DOC-13306
Adds documentation for the Index Settings REST API, including the
indexer.settings.scan_timeoutparameter.Also adds driveby fixes to the OpenAPI generator templates, including better handling of composite schemas.
We've had previous requests to document this REST API, but so far have always decided to leave it undocumented. However, over the years several references to this REST API have crept into the documentation. With this ticket, I've decided that it's time to drop the pretence and add a full reference page. I have added a warning near the top of the page to say that "you should only change the Index Service settings when advised to do so by Couchbase Support".
There are a lot of changed files, but the only ones you really need to review for this ticket are index-settings.yaml and the generated index.adoc.
Docs preview: Index Settings REST API
Credentials: Preview docs for internal review
Must be merged at the same time as the following PRs: