AV-90385 Azure cluster updates #240

PaulomeeCb · 2024-11-09T03:05:11Z

Jira

Description

In this PR, I am doing the following -

Update will read the plan and if it finds the default values for iops and storage in premium-type disks, then it will not throw an error, else if the user explicitly adds some other values, it throws an error. This will be caught in terraform before passing to open-api.
Create will not allow passing any values for iops and storage for premium-type disks, and this is caught at terraform before passing to open-api. Hence, the error is thrown after terraform apply from terraform.
Updated the README and example files for more clarity on Premium and ultra type disks for azure clusters.

All tests documented here- https://docs.google.com/document/d/1oIYkLpuiGcO_05Pkon0JIUYt-VmxojHCKWn4AX1F7oY/edit?tab=t.0

Type of Change

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
This change requires a documentation update
Documentation fix/enhancement

Manual Testing Approach

All tests documented here- https://docs.google.com/document/d/1oIYkLpuiGcO_05Pkon0JIUYt-VmxojHCKWn4AX1F7oY/edit?tab=t.0

Deploying Ultra-type Azure cluster -

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Outputs:

cluster_id = "c142f957-edac-4bc1-aff4-90d7cde7b007"
new_cluster = {
  "app_service_id" = tostring(null)
  "audit" = {
    "created_at" = "2024-11-13 18:49:32.43634667 +0000 UTC"
    "created_by" = "CCaCemREbxLhyNfRg61d4ukDW75nWn1I"
    "modified_at" = "2024-11-13 18:55:26.536605251 +0000 UTC"
    "modified_by" = "apikey-CCaCemREbxLhyNfRg61d4ukDW75nWn1I"
    "version" = 3
  }
  "availability" = {
    "type" = "single"
  }
  "cloud_provider" = {
    "cidr" = "10.0.0.0/23"
    "region" = "eastus"
    "type" = "azure"
  }
  "configuration_type" = "multiNode"
  "connection_string" = "cb.sstd0a1ssoq-qz.aws-guardians.nonprod-project-avengers.com"
  "couchbase_server" = {
    "version" = "7.6"
  }
  "current_state" = "healthy"
  "description" = "My first test cluster for multiple services."
  "enable_private_dns_resolution" = false
  "etag" = "Version: 3"
  "id" = "c142f957-edac-4bc1-aff4-90d7cde7b007"
  "if_match" = tostring(null)
  "name" = "TF Azure Ultra"
  "organization_id" = "adb4fb4c-1d98-4287-ac33-230742d2cc76"
  "project_id" = "c09035e8-3971-4b79-a6ec-bccd9056041f"
  "service_groups" = toset([
    {
      "node" = {
        "compute" = {
          "cpu" = 4
          "ram" = 16
        }
        "disk" = {
          "autoexpansion" = true
          "iops" = 3000
          "storage" = 64
          "type" = "Ultra"
        }
      }
      "num_of_nodes" = 3
      "services" = toset([
        "data",
      ])
    },
  ])
  "support" = {
    "plan" = "developer pro"
    "timezone" = "PT"
  }
}

Deployed successfully -

Updating Ultra-type Azure cluster-

~ update in-place

Terraform will perform the following actions:

  # couchbase-capella_cluster.new_cluster will be updated in-place
  ~ resource "couchbase-capella_cluster" "new_cluster" {
      + app_service_id                = (known after apply)
      ~ audit                         = {
          ~ created_at  = "2024-11-13 18:49:32.43634667 +0000 UTC" -> (known after apply)
          ~ created_by  = "CCaCemREbxLhyNfRg61d4ukDW75nWn1I" -> (known after apply)
          ~ modified_at = "2024-11-13 18:55:26.536605251 +0000 UTC" -> (known after apply)
          ~ modified_by = "apikey-CCaCemREbxLhyNfRg61d4ukDW75nWn1I" -> (known after apply)
          ~ version     = 3 -> (known after apply)
        } -> (known after apply)
      ~ connection_string             = "cb.sstd0a1ssoq-qz.aws-guardians.nonprod-project-avengers.com" -> (known after apply)
      ~ current_state                 = "healthy" -> (known after apply)
      ~ etag                          = "Version: 3" -> (known after apply)
        id                            = "c142f957-edac-4bc1-aff4-90d7cde7b007"
        name                          = "TF Azure Ultra"
      ~ service_groups                = [
          - {
              - node         = {
                  - compute = {
                      - cpu = 4 -> null
                      - ram = 16 -> null
                    } -> null
                  - disk    = {
                      - autoexpansion = true -> null
                      - iops          = 3000 -> null
                      - storage       = 64 -> null
                      - type          = "Ultra" -> null
                    } -> null
                } -> null
              - num_of_nodes = 3 -> null
              - services     = [
                  - "data",
                ] -> null
            },
          + {
              + node         = {
                  + compute = {
                      + cpu = 4
                      + ram = 16
                    }
                  + disk    = {
                      + autoexpansion = true
                      + iops          = 4000
                      + storage       = 128
                      + type          = "Ultra"
                    }
                }
              + num_of_nodes = 3
              + services     = [
                  + "data",
                ]
            },
        ]
      ~ support                       = {
          ~ timezone = "PT" -> "GMT"
            # (1 unchanged attribute hidden)
        }
        # (8 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Changes to Outputs:
  ~ new_cluster = {
      + app_service_id                = (known after apply)
      ~ audit                         = {
          - created_at  = "2024-11-13 18:49:32.43634667 +0000 UTC"
          - created_by  = "CCaCemREbxLhyNfRg61d4ukDW75nWn1I"
          - modified_at = "2024-11-13 18:55:26.536605251 +0000 UTC"
          - modified_by = "apikey-CCaCemREbxLhyNfRg61d4ukDW75nWn1I"
          - version     = 3
        } -> (known after apply)
      ~ connection_string             = "cb.sstd0a1ssoq-qz.aws-guardians.nonprod-project-avengers.com" -> (known after apply)
      ~ current_state                 = "healthy" -> (known after apply)
      ~ etag                          = "Version: 3" -> (known after apply)
        id                            = "c142f957-edac-4bc1-aff4-90d7cde7b007"
        name                          = "TF Azure Ultra"
      ~ service_groups                = [
          ~ {
              ~ node         = {
                  ~ disk    = {
                      ~ iops          = 3000 -> 4000
                      ~ storage       = 64 -> 128
                        # (2 unchanged attributes hidden)
                    }
                    # (1 unchanged attribute hidden)
                }
                # (2 unchanged attributes hidden)
            },
        ]
      ~ support                       = {
          ~ timezone = "PT" -> "GMT"
            # (1 unchanged attribute hidden)
        }
        # (9 unchanged attributes hidden)
    }
2024-11-13T11:06:35.775-0800 [DEBUG] command: asking for input: "\nDo you want to perform these actions?"

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

Updated-

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

Outputs:

cluster_id = "c142f957-edac-4bc1-aff4-90d7cde7b007"
new_cluster = {
  "app_service_id" = tostring(null)
  "audit" = {
    "created_at" = "2024-11-13 18:49:32.43634667 +0000 UTC"
    "created_by" = "CCaCemREbxLhyNfRg61d4ukDW75nWn1I"
    "modified_at" = "2024-11-13 19:20:06.276514922 +0000 UTC"
    "modified_by" = "apikey-Bbmh0bvuZJWriP7lUIafeVh4RS7i8HHz"
    "version" = 7
  }
  "availability" = {
    "type" = "single"
  }
  "cloud_provider" = {
    "cidr" = "10.0.0.0/23"
    "region" = "eastus"
    "type" = "azure"
  }
  "configuration_type" = "multiNode"
  "connection_string" = "cb.sstd0a1ssoq-qz.aws-guardians.nonprod-project-avengers.com"
  "couchbase_server" = {
    "version" = "7.6"
  }
  "current_state" = "healthy"
  "description" = "My first test cluster for multiple services."
  "enable_private_dns_resolution" = false
  "etag" = "Version: 7"
  "id" = "c142f957-edac-4bc1-aff4-90d7cde7b007"
  "if_match" = tostring(null)
  "name" = "TF Azure Ultra"
  "organization_id" = "adb4fb4c-1d98-4287-ac33-230742d2cc76"
  "project_id" = "c09035e8-3971-4b79-a6ec-bccd9056041f"
  "service_groups" = toset([
    {
      "node" = {
        "compute" = {
          "cpu" = 4
          "ram" = 16
        }
        "disk" = {
          "autoexpansion" = true
          "iops" = 4000
          "storage" = 128
          "type" = "Ultra"
        }
      }
      "num_of_nodes" = 3
      "services" = toset([
        "data",
      ])
    },
  ])
  "support" = {
    "plan" = "developer pro"
    "timezone" = "GMT"
  }
}

Correct error thrown when wrong values added-

╷
│ Error: Error updating cluster
│ 
│   with couchbase-capella_cluster.new_cluster,
│   on create_cluster.tf line 9, in resource "couchbase-capella_cluster" "new_cluster":
│    9: resource "couchbase-capella_cluster" "new_cluster" {
│ 
│ Could not update cluster id "c142f957-edac-4bc1-aff4-90d7cde7b007": {"hint":"Please ensure the IOPS value is in the correct range for the selected Ultra disk size.","message":"Unable to process
│ deployment for cluster. The IOPS to storage ratio is violated for the disk (Ultra). IOPS value must be between '4000' and '80000' for Ultra disk with 128 GiB.","code":4060,"httpStatusCode":422}

Deploying Premium-type Azure cluster-

Testing added to the Readme

Throws correct error when Iops and Storage is added in payload for Create-

│ Error: Error updating cluster
│ 
│   with couchbase-capella_cluster.new_cluster,
│   on create_cluster.tf line 9, in resource "couchbase-capella_cluster" "new_cluster":
│    9: resource "couchbase-capella_cluster" "new_cluster" {
│ 
│ Could not update cluster id "e809cd1b-6bbe-48d7-9541-42ae387ebccf": {"hint":"Please do not specify disk size or IOPS for this disk type when attempting to deploy a cluster.","message":"Unable to process
│ deployment for cluster. Cannot specify disk size or IOPS for disk type P6","code":4029,"httpStatusCode":422}
╵

Update is successful-

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # couchbase-capella_cluster.new_cluster will be updated in-place
  ~ resource "couchbase-capella_cluster" "new_cluster" {
      + app_service_id                = (known after apply)
      ~ audit                         = {
          ~ created_at  = "2024-11-14 22:56:17.081484886 +0000 UTC" -> (known after apply)
          ~ created_by  = "Bbmh0bvuZJWriP7lUIafeVh4RS7i8HHz" -> (known after apply)
          ~ modified_at = "2024-11-14 23:52:15.956663593 +0000 UTC" -> (known after apply)
          ~ modified_by = "apikey-Bbmh0bvuZJWriP7lUIafeVh4RS7i8HHz" -> (known after apply)
          ~ version     = 7 -> (known after apply)
        } -> (known after apply)
      ~ connection_string             = "cb.mswerv2si5ugovmx.aws-guardians.nonprod-project-avengers.com" -> (known after apply)
      ~ current_state                 = "healthy" -> (known after apply)
      ~ etag                          = "Version: 7" -> (known after apply)
        id                            = "e809cd1b-6bbe-48d7-9541-42ae387ebccf"
        name                          = "TF Azure P6"
      ~ support                       = {
          ~ timezone = "GMT" -> "PT"
            # (1 unchanged attribute hidden)
        }
        # (9 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Changes to Outputs:
  ~ new_cluster = {
      + app_service_id                = (known after apply)
      ~ audit                         = {
          - created_at  = "2024-11-14 22:56:17.081484886 +0000 UTC"
          - created_by  = "Bbmh0bvuZJWriP7lUIafeVh4RS7i8HHz"
          - modified_at = "2024-11-14 23:52:15.956663593 +0000 UTC"
          - modified_by = "apikey-Bbmh0bvuZJWriP7lUIafeVh4RS7i8HHz"
          - version     = 7
        } -> (known after apply)
      ~ connection_string             = "cb.mswerv2si5ugovmx.aws-guardians.nonprod-project-avengers.com" -> (known after apply)
      ~ current_state                 = "healthy" -> (known after apply)
      ~ etag                          = "Version: 7" -> (known after apply)
        id                            = "e809cd1b-6bbe-48d7-9541-42ae387ebccf"
        name                          = "TF Azure P6"
      ~ support                       = {
          ~ timezone = "GMT" -> "PT"
            # (1 unchanged attribute hidden)
        }
        # (10 unchanged attributes hidden)
    }
2024-11-14T15:55:59.905-0800 [DEBUG] command: asking for input: "\nDo you want to perform these actions?"

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

couchbase-capella_cluster.new_cluster: Still modifying... [id=e809cd1b-6bbe-48d7-9541-42ae387ebccf, 10s elapsed]
couchbase-capella_cluster.new_cluster: Still modifying... [id=e809cd1b-6bbe-48d7-9541-42ae387ebccf, 20s elapsed]
couchbase-capella_cluster.new_cluster: Still modifying... [id=e809cd1b-6bbe-48d7-9541-42ae387ebccf, 30s elapsed]
couchbase-capella_cluster.new_cluster: Still modifying... [id=e809cd1b-6bbe-48d7-9541-42ae387ebccf, 40s elapsed]
couchbase-capella_cluster.new_cluster: Still modifying... [id=e809cd1b-6bbe-48d7-9541-42ae387ebccf, 50s elapsed]
couchbase-capella_cluster.new_cluster: Still modifying... [id=e809cd1b-6bbe-48d7-9541-42ae387ebccf, 1m0s elapsed]
couchbase-capella_cluster.new_cluster: Still modifying... [id=e809cd1b-6bbe-48d7-9541-42ae387ebccf, 1m10s elapsed]
couchbase-capella_cluster.new_cluster: Still modifying... [id=e809cd1b-6bbe-48d7-9541-42ae387ebccf, 1m20s elapsed]
couchbase-capella_cluster.new_cluster: Still modifying... [id=e809cd1b-6bbe-48d7-9541-42ae387ebccf, 1m30s elapsed]
couchbase-capella_cluster.new_cluster: Still modifying... [id=e809cd1b-6bbe-48d7-9541-42ae387ebccf, 1m40s elapsed]
couchbase-capella_cluster.new_cluster: Still modifying... [id=e809cd1b-6bbe-48d7-9541-42ae387ebccf, 1m50s elapsed]
couchbase-capella_cluster.new_cluster: Still modifying... [id=e809cd1b-6bbe-48d7-9541-42ae387ebccf, 2m0s elapsed]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

Outputs:

cluster_id = "e809cd1b-6bbe-48d7-9541-42ae387ebccf"
new_cluster = {
  "app_service_id" = tostring(null)
  "audit" = {
    "created_at" = "2024-11-14 22:56:17.081484886 +0000 UTC"
    "created_by" = "Bbmh0bvuZJWriP7lUIafeVh4RS7i8HHz"
    "modified_at" = "2024-11-14 23:56:44.685274551 +0000 UTC"
    "modified_by" = "apikey-Bbmh0bvuZJWriP7lUIafeVh4RS7i8HHz"
    "version" = 11
  }
  "availability" = {
    "type" = "single"
  }
  "cloud_provider" = {
    "cidr" = "10.0.0.0/23"
    "region" = "eastus"
    "type" = "azure"
  }
  "configuration_type" = "multiNode"
  "connection_string" = "cb.mswerv2si5ugovmx.aws-guardians.nonprod-project-avengers.com"
  "couchbase_server" = {
    "version" = "7.6"
  }
  "current_state" = "healthy"
  "description" = "My first test cluster for multiple services."
  "enable_private_dns_resolution" = false
  "etag" = "Version: 11"
  "id" = "e809cd1b-6bbe-48d7-9541-42ae387ebccf"
  "if_match" = tostring(null)
  "name" = "TF Azure P6"
  "organization_id" = "adb4fb4c-1d98-4287-ac33-230742d2cc76"
  "project_id" = "c09035e8-3971-4b79-a6ec-bccd9056041f"
  "service_groups" = toset([
    {
      "node" = {
        "compute" = {
          "cpu" = 4
          "ram" = 16
        }
        "disk" = {
          "autoexpansion" = true
          "iops" = 240
          "storage" = 64
          "type" = "P6"
        }
      }
      "num_of_nodes" = 3
      "services" = toset([
        "data",
      ])
    },
  ])
  "support" = {
    "plan" = "developer pro"
    "timezone" = "PT"
  }
}

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

Manually tested
Unit tested
Acceptance tested
Unable to test / will not test (Please provide comments in section below)

Testing

Will add ss/ recording.

Testing

modified the acc test and adding the output TF_ACC=1 go test -timeout=360m -failfast=false -run '^TestAccggh$|^TestAccClusterResourceAzure$|^Testjg$' -v ./internal/resources/acceptance_tests === RUN TestAccClusterResourceAzure === PAUSE TestAccClusterResourceAzure === CONT TestAccClusterResourceAzure raw state map[%:18 audit.%:5 audit.created_at:2024-11-11 13:33:14.535739196 +0000 UTC audit.created_by:kLpLDGfOLgs1kekFzG9EsvfDMl20KhYg audit.modified_at:2024-11-11 13:37:13.460988849 +0000 UTC audit.modified_by:apikey-kLpLDGfOLgs1kekFzG9EsvfDMl20KhYg audit.version:3 availability.%:1 availability.type:multi cloud_provider.%:3 cloud_provider.cidr:10.252.250.0/23 cloud_provider.region:eastus cloud_provider.type:azure configuration_type:multiNode connection_string:cb.qx74f-mjwglwyzva.sandbox.nonprod-project-avengers.com couchbase_server.%:1 couchbase_server.version:7.6 current_state:healthy description:My first test cluster for multiple services. enable_private_dns_resolution:false etag:Version: 3 id:a7602544-05c2-4493-863e-42590199c6cd name:Terraform Acceptance Test Cluster organization_id:0ba1d229-c891-4a9d-b59c-de46f97f18e1 project_id:cfe71ce5-4bc0-4263-adba-538702595708 service_groups.#:1 service_groups.0.%:3 service_groups.0.node.%:2 service_groups.0.node.compute.%:2 service_groups.0.node.compute.cpu:4 service_groups.0.node.compute.ram:16 service_groups.0.node.disk.%:4 service_groups.0.node.disk.autoexpansion:true service_groups.0.node.disk.iops:240 service_groups.0.node.disk.storage:64 service_groups.0.node.disk.type:P6 service_groups.0.num_of_nodes:3 service_groups.0.services.#:3 service_groups.0.services.0:data service_groups.0.services.1:index service_groups.0.services.2:query support.%:2 support.plan:developer pro support.timezone:GMT]raw state map[%:18 audit.%:5 audit.created_at:2024-11-11 13:33:14.535739196 +0000 UTC audit.created_by:kLpLDGfOLgs1kekFzG9EsvfDMl20KhYg audit.modified_at:2024-11-11 13:37:13.460988849 +0000 UTC audit.modified_by:apikey-kLpLDGfOLgs1kekFzG9EsvfDMl20KhYg audit.version:3 availability.%:1 availability.type:multi cloud_provider.%:3 cloud_provider.cidr:10.252.250.0/23 cloud_provider.region:eastus cloud_provider.type:azure configuration_type:multiNode connection_string:cb.qx74f-mjwglwyzva.sandbox.nonprod-project-avengers.com couchbase_server.%:1 couchbase_server.version:7.6 current_state:healthy description:My first test cluster for multiple services. enable_private_dns_resolution:false etag:Version: 3 id:a7602544-05c2-4493-863e-42590199c6cd name:Terraform Acceptance Test Cluster organization_id:0ba1d229-c891-4a9d-b59c-de46f97f18e1 project_id:cfe71ce5-4bc0-4263-adba-538702595708 service_groups.#:1 service_groups.0.%:3 service_groups.0.node.%:2 service_groups.0.node.compute.%:2 service_groups.0.node.compute.cpu:4 service_groups.0.node.compute.ram:16 service_groups.0.node.disk.%:4 service_groups.0.node.disk.autoexpansion:true service_groups.0.node.disk.iops:240 service_groups.0.node.disk.storage:64 service_groups.0.node.disk.type:P6 service_groups.0.num_of_nodes:3 service_groups.0.services.#:3 service_groups.0.services.0:data service_groups.0.services.1:index service_groups.0.services.2:query support.%:2 support.plan:developer pro support.timezone:GMT]raw state map[%:18 audit.%:5 audit.created_at:2024-11-11 13:33:14.535739196 +0000 UTC audit.created_by:kLpLDGfOLgs1kekFzG9EsvfDMl20KhYg audit.modified_at:2024-11-11 13:46:23.653342331 +0000 UTC audit.modified_by:apikey-kLpLDGfOLgs1kekFzG9EsvfDMl20KhYg audit.version:8 availability.%:1 availability.type:multi cloud_provider.%:3 cloud_provider.cidr:10.252.250.0/23 cloud_provider.region:eastus cloud_provider.type:azure configuration_type:multiNode connection_string:cb.qx74f-mjwglwyzva.sandbox.nonprod-project-avengers.com couchbase_server.%:1 couchbase_server.version:7.6 current_state:healthy description:My first test cluster for multiple services. enable_private_dns_resolution:false etag:Version: 8 id:a7602544-05c2-4493-863e-42590199c6cd name:Terraform Acceptance Test Cluster organization_id:0ba1d229-c891-4a9d-b59c-de46f97f18e1 project_id:cfe71ce5-4bc0-4263-adba-538702595708 service_groups.#:1 service_groups.0.%:3 service_groups.0.node.%:2 service_groups.0.node.compute.%:2 service_groups.0.node.compute.cpu:4 service_groups.0.node.compute.ram:32 service_groups.0.node.disk.%:4 service_groups.0.node.disk.autoexpansion:false service_groups.0.node.disk.iops:17000 service_groups.0.node.disk.storage:1024 service_groups.0.node.disk.type:Ultra service_groups.0.num_of_nodes:3 service_groups.0.services.#:3 service_groups.0.services.0:data service_groups.0.services.1:index service_groups.0.services.2:query support.%:2 support.plan:developer pro support.timezone:PT]raw state map[%:18 audit.%:5 audit.created_at:2024-11-11 13:33:14.535739196 +0000 UTC audit.created_by:kLpLDGfOLgs1kekFzG9EsvfDMl20KhYg audit.modified_at:2024-11-11 13:56:56.622534868 +0000 UTC audit.modified_by:apikey-kLpLDGfOLgs1kekFzG9EsvfDMl20KhYg audit.version:13 availability.%:1 availability.type:multi cloud_provider.%:3 cloud_provider.cidr:10.252.250.0/23 cloud_provider.region:eastus cloud_provider.type:azure configuration_type:multiNode connection_string:cb.qx74f-mjwglwyzva.sandbox.nonprod-project-avengers.com couchbase_server.%:1 couchbase_server.version:7.6 current_state:healthy description:My first test cluster for multiple services. enable_private_dns_resolution:false etag:Version: 13 id:a7602544-05c2-4493-863e-42590199c6cd name:Terraform Acceptance Test Cluster organization_id:0ba1d229-c891-4a9d-b59c-de46f97f18e1 project_id:cfe71ce5-4bc0-4263-adba-538702595708 service_groups.#:1 service_groups.0.%:3 service_groups.0.node.%:2 service_groups.0.node.compute.%:2 service_groups.0.node.compute.cpu:4 service_groups.0.node.compute.ram:16 service_groups.0.node.disk.%:4 service_groups.0.node.disk.autoexpansion:false service_groups.0.node.disk.iops:5000 service_groups.0.node.disk.storage:1024 service_groups.0.node.disk.type:P30 service_groups.0.num_of_nodes:3 service_groups.0.services.#:3 service_groups.0.services.0:data service_groups.0.services.1:index service_groups.0.services.2:query support.%:2 support.plan:developer pro support.timezone:PT]raw state map[%:18 audit.%:5 audit.created_at:2024-11-11 13:33:14.535739196 +0000 UTC audit.created_by:kLpLDGfOLgs1kekFzG9EsvfDMl20KhYg audit.modified_at:2024-11-11 14:03:30.507799326 +0000 UTC audit.modified_by:apikey-kLpLDGfOLgs1kekFzG9EsvfDMl20KhYg audit.version:18 availability.%:1 availability.type:multi cloud_provider.%:3 cloud_provider.cidr:10.252.250.0/23 cloud_provider.region:eastus cloud_provider.type:azure configuration_type:multiNode connection_string:cb.qx74f-mjwglwyzva.sandbox.nonprod-project-avengers.com couchbase_server.%:1 couchbase_server.version:7.6 current_state:healthy description:My first test cluster for multiple services. enable_private_dns_resolution:false etag:Version: 18 id:a7602544-05c2-4493-863e-42590199c6cd name:Terraform Acceptance Test Cluster organization_id:0ba1d229-c891-4a9d-b59c-de46f97f18e1 project_id:cfe71ce5-4bc0-4263-adba-538702595708 service_groups.#:2 service_groups.0.%:3 service_groups.0.node.%:2 service_groups.0.node.compute.%:2 service_groups.0.node.compute.cpu:4 service_groups.0.node.compute.ram:16 service_groups.0.node.disk.%:4 service_groups.0.node.disk.autoexpansion:false service_groups.0.node.disk.iops:17000 service_groups.0.node.disk.storage:1024 service_groups.0.node.disk.type:Ultra service_groups.0.num_of_nodes:3 service_groups.0.services.#:1 service_groups.0.services.0:data service_groups.1.%:3 service_groups.1.node.%:2 service_groups.1.node.compute.%:2 service_groups.1.node.compute.cpu:4 service_groups.1.node.compute.ram:16 service_groups.1.node.disk.%:4 service_groups.1.node.disk.autoexpansion:false service_groups.1.node.disk.iops:240 service_groups.1.node.disk.storage:64 service_groups.1.node.disk.type:P6 service_groups.1.num_of_nodes:2 service_groups.1.services.#:2 service_groups.1.services.0:index service_groups.1.services.1:query support.%:2 support.plan:enterprise support.timezone:ET]--- PASS: TestAccClusterResourceAzure (2575.72s) PASS ok github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/resources/acceptance_tests 2577.014s

Required Checklist:

I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if required)
I have run make fmt and formatted my code
I have made sure that no schema field is marked with both requiresReplace and computed

Further comments

examples/cluster/azure/terraform.template.tfvars

examples/cluster/azure/variables.tf

internal/resources/cluster.go

…um disks

SaicharanCB

+1
tested here http://172.23.121.80/job/terraform-test/789/

internal/resources/cluster.go

Azure - ultra and premium chnages

e734445

PaulomeeCb requested review from a team as code owners November 9, 2024 03:05

PaulomeeCb self-assigned this Nov 9, 2024

PaulomeeCb marked this pull request as draft November 9, 2024 03:05

PaulomeeCb and others added 5 commits November 8, 2024 19:08

Lint check resolve

2763a1c

Adding Ultra example

fec7447

modifying azure acceptance test for the fix

6e154e1

modifying azure acceptance test for the fix

8d105e6

modifying azure acceptance test for the fix

35b54d8

Talina06 reviewed Nov 12, 2024

View reviewed changes

examples/cluster/azure/terraform.template.tfvars Outdated Show resolved Hide resolved

examples/cluster/azure/variables.tf Outdated Show resolved Hide resolved

internal/resources/cluster.go Outdated Show resolved Hide resolved

internal/resources/cluster.go Outdated Show resolved Hide resolved

PaulomeeCb added 7 commits November 12, 2024 12:09

Updating as per review

541e4d1

Renaming storage to size

aad61ad

format

0f08bb5

Adding separate example files for ultra and premium

54de1cc

Readme with renaming points

91abecd

Reverting cluster.go changes

1a578c4

Updating Readme

127d1c2

PaulomeeCb changed the title ~~AV-90385 Azure cluster - ultra and premium chagNes~~ AV-90385 Azure cluster - ultra and premium changes Nov 13, 2024

Added check for terraform error when iops, storage is added for premi…

44205f7

…um disks

PaulomeeCb changed the title ~~AV-90385 Azure cluster - ultra and premium changes~~ AV-90385 Azure cluster - ultra and premium Documentation update Nov 13, 2024

Updating format

e19a506

PaulomeeCb marked this pull request as ready for review November 13, 2024 21:20

Updating readme

68d5527

PaulomeeCb marked this pull request as draft November 14, 2024 22:23

PaulomeeCb changed the title ~~AV-90385 Azure cluster - ultra and premium Documentation update~~ AV-90385 Azure cluster - premium changes Nov 15, 2024

PaulomeeCb changed the title ~~AV-90385 Azure cluster - premium changes~~ AV-90385 Azure cluster updates Nov 15, 2024

PaulomeeCb added 2 commits November 14, 2024 16:25

Adding conditions for PREMIUM

537dedf

Lint

7243d4e

PaulomeeCb marked this pull request as ready for review November 15, 2024 01:00

PaulomeeCb requested a review from Talina06 November 15, 2024 01:35

modifying acceptance test

27fd7f4

SaicharanCB previously approved these changes Nov 26, 2024

View reviewed changes

Merging main

d53419f

PaulomeeCb dismissed SaicharanCB’s stale review via d53419f November 27, 2024 06:51

PaulomeeCb requested a review from SaicharanCB November 27, 2024 06:52

SaicharanCB approved these changes Nov 27, 2024

View reviewed changes

l0n3star requested changes Nov 27, 2024

View reviewed changes

internal/resources/cluster.go Show resolved Hide resolved

l0n3star approved these changes Dec 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AV-90385 Azure cluster updates #240

AV-90385 Azure cluster updates #240

PaulomeeCb commented Nov 9, 2024 •

edited

Loading

SaicharanCB left a comment

AV-90385 Azure cluster updates #240

Are you sure you want to change the base?

AV-90385 Azure cluster updates #240

Conversation

PaulomeeCb commented Nov 9, 2024 • edited Loading

Jira

Description

Type of Change

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

Testing

Required Checklist:

Further comments

SaicharanCB left a comment

Choose a reason for hiding this comment

PaulomeeCb commented Nov 9, 2024 •

edited

Loading