Fix grammar issue #2785
Merged
Fix grammar issue #2785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo `can trigger` repeating twice in the `Eventing Keyspaces` section
As we only have Data Service, let us be consistent across as Data Service provider seems like another term for Data Service
Added language feature incorrectly positioned in the removed language features list
Add item under language restriction; importing libraries is not allowed
Import libs is restricted
Fix grammar issue
CAS is allowed to be set, albeit, it is a no-op in the upsert operation. Hence it is incorrect to document that upsert does not allow setting CAS for the document.
Grammer issue
simon-dew
requested changes
Nov 1, 2024
modules/eventing/pages/eventing-advanced-keyspace-accessors.adoc
Outdated
Show resolved
Hide resolved
simon-dew
approved these changes
Nov 1, 2024
|
Thanks for the contribution! |
|
Note to self:
|
simon-dew
added a commit
that referenced
this pull request
Nov 1, 2024
* Typo `can trigger` repeating twice in the `Eventing Keyspaces` section * As we only have Data Service, let us be consistent across as Data Service provider seems like another term for Data Service * Added language feature incorrectly positioned in the removed language features list * Add item under language restriction; importing libraries is not allowed * Import libs is restricted * Fix grammar issue in eventing-language-constructs * CAS is allowed to be set, albeit, it is a no-op in the upsert operation. Hence it is incorrect to document that upsert does not allow setting CAS for the document. * Fix grammar issue in eventing-timers.adoc * Updates after review --------- Co-authored-by: Simon Dew <[email protected]>
simon-dew
added a commit
that referenced
this pull request
Nov 1, 2024
* Typo `can trigger` repeating twice in the `Eventing Keyspaces` section * As we only have Data Service, let us be consistent across as Data Service provider seems like another term for Data Service * Added language feature incorrectly positioned in the removed language features list * Add item under language restriction; importing libraries is not allowed * Import libs is restricted * Fix grammar issue in eventing-language-constructs * CAS is allowed to be set, albeit, it is a no-op in the upsert operation. Hence it is incorrect to document that upsert does not allow setting CAS for the document. * Fix grammar issue in eventing-timers.adoc * Updates after review --------- Co-authored-by: Simon Dew <[email protected]>
simon-dew
added a commit
that referenced
this pull request
Nov 1, 2024
* Typo `can trigger` repeating twice in the `Eventing Keyspaces` section * As we only have Data Service, let us be consistent across as Data Service provider seems like another term for Data Service * Added language feature incorrectly positioned in the removed language features list * Add item under language restriction; importing libraries is not allowed * Import libs is restricted * Fix grammar issue in eventing-language-constructs * CAS is allowed to be set, albeit, it is a no-op in the upsert operation. Hence it is incorrect to document that upsert does not allow setting CAS for the document. * Fix grammar issue in eventing-timers.adoc * Updates after review --------- Co-authored-by: Simon Dew <[email protected]>
simon-dew
added a commit
that referenced
this pull request
Nov 1, 2024
* Typo `can trigger` repeating twice in the `Eventing Keyspaces` section * As we only have Data Service, let us be consistent across as Data Service provider seems like another term for Data Service * Added language feature incorrectly positioned in the removed language features list * Add item under language restriction; importing libraries is not allowed * Import libs is restricted * Fix grammar issue in eventing-language-constructs * CAS is allowed to be set, albeit, it is a no-op in the upsert operation. Hence it is incorrect to document that upsert does not allow setting CAS for the document. * Fix grammar issue in eventing-timers.adoc * Updates after review --------- Co-authored-by: Simon Dew <[email protected]>
simon-dew
added a commit
to couchbaselabs/docs-devex
that referenced
this pull request
Nov 1, 2024
* Typo `can trigger` repeating twice in the `Eventing Keyspaces` section * As we only have Data Service, let us be consistent across as Data Service provider seems like another term for Data Service * Added language feature incorrectly positioned in the removed language features list * Add item under language restriction; importing libraries is not allowed * Import libs is restricted * Fix grammar issue in eventing-language-constructs * CAS is allowed to be set, albeit, it is a no-op in the upsert operation. Hence it is incorrect to document that upsert does not allow setting CAS for the document. * Fix grammar issue in eventing-timers.adoc * Updates after review --------- Co-authored-by: Simon Dew <[email protected]>
simon-dew
added a commit
to couchbaselabs/docs-devex
that referenced
this pull request
Nov 1, 2024
* Typo `can trigger` repeating twice in the `Eventing Keyspaces` section * As we only have Data Service, let us be consistent across as Data Service provider seems like another term for Data Service * Added language feature incorrectly positioned in the removed language features list * Add item under language restriction; importing libraries is not allowed * Import libs is restricted * Fix grammar issue in eventing-language-constructs * CAS is allowed to be set, albeit, it is a no-op in the upsert operation. Hence it is incorrect to document that upsert does not allow setting CAS for the document. * Fix grammar issue in eventing-timers.adoc * Updates after review --------- Co-authored-by: Simon Dew <[email protected]>
simon-dew
added a commit
to couchbaselabs/docs-devex
that referenced
this pull request
Nov 12, 2024
* Typo `can trigger` repeating twice in the `Eventing Keyspaces` section * As we only have Data Service, let us be consistent across as Data Service provider seems like another term for Data Service * Added language feature incorrectly positioned in the removed language features list * Add item under language restriction; importing libraries is not allowed * Import libs is restricted * Fix grammar issue in eventing-language-constructs * CAS is allowed to be set, albeit, it is a no-op in the upsert operation. Hence it is incorrect to document that upsert does not allow setting CAS for the document. * Fix grammar issue in eventing-timers.adoc * Updates after review --------- Co-authored-by: Simon Dew <[email protected]>
simon-dew
added a commit
to couchbaselabs/docs-devex
that referenced
this pull request
Nov 12, 2024
* Typo `can trigger` repeating twice in the `Eventing Keyspaces` section * As we only have Data Service, let us be consistent across as Data Service provider seems like another term for Data Service * Added language feature incorrectly positioned in the removed language features list * Add item under language restriction; importing libraries is not allowed * Import libs is restricted * Fix grammar issue in eventing-language-constructs * CAS is allowed to be set, albeit, it is a no-op in the upsert operation. Hence it is incorrect to document that upsert does not allow setting CAS for the document. * Fix grammar issue in eventing-timers.adoc * Updates after review --------- Co-authored-by: Simon Dew <[email protected]>
sarahlwelton
pushed a commit
to couchbaselabs/docs-devex
that referenced
this pull request
Nov 18, 2024
* Typo `can trigger` repeating twice in the `Eventing Keyspaces` section * As we only have Data Service, let us be consistent across as Data Service provider seems like another term for Data Service * Added language feature incorrectly positioned in the removed language features list * Add item under language restriction; importing libraries is not allowed * Import libs is restricted * Fix grammar issue in eventing-language-constructs * CAS is allowed to be set, albeit, it is a no-op in the upsert operation. Hence it is incorrect to document that upsert does not allow setting CAS for the document. * Fix grammar issue in eventing-timers.adoc * Updates after review --------- Co-authored-by: Simon Dew <[email protected]>
simon-dew
added a commit
to couchbaselabs/docs-devex
that referenced
this pull request
Dec 3, 2024
* Typo `can trigger` repeating twice in the `Eventing Keyspaces` section * As we only have Data Service, let us be consistent across as Data Service provider seems like another term for Data Service * Added language feature incorrectly positioned in the removed language features list * Add item under language restriction; importing libraries is not allowed * Import libs is restricted * Fix grammar issue in eventing-language-constructs * CAS is allowed to be set, albeit, it is a no-op in the upsert operation. Hence it is incorrect to document that upsert does not allow setting CAS for the document. * Fix grammar issue in eventing-timers.adoc * Updates after review --------- Co-authored-by: Simon Dew <[email protected]>
simon-dew
added a commit
to couchbaselabs/docs-devex
that referenced
this pull request
Dec 4, 2024
* Typo `can trigger` repeating twice in the `Eventing Keyspaces` section * As we only have Data Service, let us be consistent across as Data Service provider seems like another term for Data Service * Added language feature incorrectly positioned in the removed language features list * Add item under language restriction; importing libraries is not allowed * Import libs is restricted * Fix grammar issue in eventing-language-constructs * CAS is allowed to be set, albeit, it is a no-op in the upsert operation. Hence it is incorrect to document that upsert does not allow setting CAS for the document. * Fix grammar issue in eventing-timers.adoc * Updates after review --------- Co-authored-by: Simon Dew <[email protected]>
simon-dew
added a commit
to couchbaselabs/docs-devex
that referenced
this pull request
Dec 11, 2024
This reverts commit 2702248.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.