-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix benchmarks build #995
Fix benchmarks build #995
Conversation
One of dev dependencies pulls rayon 1.7.0, and its dependency rayon-core 1.11.0 now requires rust 1.59+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilammy wdyt
I don't think this fixes the issue. RustThemis CI jobs didn't run here, but I'm thinking they won't pass.
The linked job fails because one of the transitive dependencies requires Rust 1.59 now. I see three ways around it:
|
so, lets pin version of the dependency? can we do it, @iamnotacake ? |
One of dev dependencies pulls rayon 1.7.0, and its dependency rayon-core 1.11.0 now requires rust 1.59+
Freeze
rayon
so it will pull a bit olderrayon-core
See failed job for the cause of this PR
Checklist
Benchmark results are attached (if applicable)Public API has proper documentationExample projects and code samples are up-to-date (in case of API changes)Changelog is updated (in case of notable or breaking changes)