Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesigned the framework to make it less vulnerable exceptions #962

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Redesigned the framework to make it less vulnerable exceptions #962

merged 2 commits into from
Nov 1, 2022

Conversation

radetsky
Copy link
Contributor

@radetsky radetsky commented Nov 1, 2022

Copy of #955 to master

  • redesigned the framework to make it less vulnerable to native exceptions.

  • restore the previous format

  • no more short names

Checklist

  • The [coding guidelines] are followed

@radetsky
Redesigned the framework to make it less vulnerable to native excepti…
6bad342 
…ons. (#955)

* redesigned the framework to make it less vulnerable to native exceptions. Second try.

* restore previous format

* no more short names
vixentael
vixentael approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i trust that you haven't put any backdoor here :D

@vixentael vixentael added O-ReactNative ⚛️ ReactNative platform W-RNThemis ⚛️ Wrapper: ReactNative Themis labels Nov 1, 2022
@vixentael
Copy link
Contributor

also, please update the change log

@radetsky
Copy link
Contributor Author

radetsky commented Nov 1, 2022

No backdoors, just the code. :)
The changelog will be updated with dedicated PR into release/0.14 and the master branch.

@radetsky radetsky merged commit 7cc43e8 into master Nov 1, 2022
@radetsky radetsky deleted the rad-dev-rn-1 branch November 1, 2022 19:34
@ilammy ilammy added this to the 0.15.0 milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vixentael vixentael vixentael approved these changes

@Lagovas Lagovas Awaiting requested review from Lagovas Lagovas is a code owner

Assignees
No one assigned
Labels
O-ReactNative ⚛️ ReactNative platform W-RNThemis ⚛️ Wrapper: ReactNative Themis
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@radetsky @vixentael @ilammy