Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of optional context for Secure Cell Token Protect and Seal #906

Merged
merged 4 commits into from
Mar 15, 2022
Merged

Improve handling of optional context for Secure Cell Token Protect and Seal #906

merged 4 commits into from
Mar 15, 2022

Conversation

radetsky
Copy link
Contributor

Checklist

  • Change is covered by automated tests
  • Benchmark results are attached (if applicable)
  • The coding guidelines are followed
  • Public API has proper documentation
  • Example projects and code samples are up-to-date (in case of API changes)
  • Changelog is updated (in case of notable or breaking changes)

@vixentael vixentael changed the title React native themis3 Improve handling of optional context for Secure Cell Token Protect and Seal Mar 15, 2022
@Lagovas
Copy link
Collaborator

Lagovas commented Mar 15, 2022

can we test it somehow?

@vixentael vixentael merged commit 7147271 into master Mar 15, 2022
@radetsky
Copy link
Contributor Author

I have tested it manually.
I'd like to use jest or some other methods, but we can't test native modules with JS together.
I already investigated it. Because JS can not run native code.

@ilammy ilammy deleted the react-native-themis3 branch March 16, 2022 11:05
radetsky added a commit that referenced this pull request Apr 5, 2022
@radetsky
Improve handling of optional context for Secure Cell Token Protect an…
a98f456 
…d Seal (#906)

* update README and example to use 0.14.3 version from npm registry

* add typescript types

* optional context, declarations file
vixentael added a commit that referenced this pull request Apr 6, 2022
@radetsky @vixentael @ilammy
Release of React Native Themis (#908)
2667a99 
* Adding React Native Themis (#902)

* added react-native support

* rename secureCell functions

* remove themis framework from source tree

* extremely new example for RNThemis

* added README.md for npm package

* Update src/wrappers/themis/react-native-themis/react-native-themis.podspec

Co-authored-by: vixentael <[email protected]>

* Update src/wrappers/themis/react-native-themis/package.json

Co-authored-by: vixentael <[email protected]>

* Update src/wrappers/themis/react-native-themis/android/src/main/java/com/reactnativethemis/ThemisModule.java

Co-authored-by: vixentael <[email protected]>

Co-authored-by: vixentael <[email protected]>

* update readme, mention themis rn (#903)

* update README and example to use 0.14.3 version from npm registry (#905)

* Improve handling of optional context for Secure Cell Token Protect and Seal (#906)

* update README and example to use 0.14.3 version from npm registry

* add typescript types

* optional context, declarations file

* update CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Alexei Lozovsky <[email protected]>

* Update CHANGELOG.md

Co-authored-by: vixentael <[email protected]>

Co-authored-by: vixentael <[email protected]>
Co-authored-by: Alexei Lozovsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vixentael vixentael vixentael approved these changes

@ilammy ilammy Awaiting requested review from ilammy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@radetsky @Lagovas @vixentael