Stop testing objthemis_boring scheme
#885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subspec is going away, stop testing it.
ilammy
added
W-SwiftThemis 🔶
|
I am not going to wait for tests to complete here. I'll let #883 actually check it against actual podspec without those subspecs. |
vixentael
approved these changes
Dec 20, 2021
|
totally agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As USA's experience teaches us, if you want to nuke somebody, you should do it twice
It would be nice if before removing the subspecs we removed their users in our own code. Drop the unit tests verifying ObjCThemis against BoringSSL.
Checklist
Example projects and code samples are up-to-date(they are pinned to 0.13, will update later)