Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M1 simulator fix: Removed arm64 from excluded archs #865

Merged
merged 2 commits into from
Jul 26, 2021
Merged

M1 simulator fix: Removed arm64 from excluded archs #865

merged 2 commits into from
Jul 26, 2021

Conversation

julepka
Copy link
Contributor

@julepka julepka commented Jul 26, 2021 •
edited
Loading

Themis XCFramework was missing arm64 architecture that is required for M1 simulators.
Reported in #864

I have removed arm64 from the excluded architectures in Themis.xcodeproj to resolve the issue. After that, Themis XCFrameworks is building with the required arm64 simulator slice.

I'm going to publish a release with the new XCFramework attached. The update with touch all package managers.

Checklist

  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has proper documentation
  • Example projects and code samples are up-to-date (in case of API changes)
  • Changelog is updated (in case of notable or breaking changes)

@vixentael
Copy link
Contributor

Does OpenSSL package require similar changes?

@julepka
Copy link
Contributor Author

julepka commented Jul 26, 2021

Does OpenSSL package require similar changes?

Nope, it is good.

@julepka julepka added M1 O-iOS 📱 Operating system: iOS M-Carthage Package manager: Carthage, Objective-C and Swift, iOS and macOS M-CocoaPods Package manager: CocoaPods, Objective-C and Swift, iOS and macOS M-SPM Package manager: Swift Package Manager, Swift, iOS and macOS labels Jul 26, 2021
@julepka julepka linked an issue Jul 26, 2021 that may be closed by this pull request
XCFramework missing ARM64 symbols for Simulator #864
Closed
2 tasks
@julepka julepka marked this pull request as ready for review July 26, 2021 09:28
@julepka julepka requested a review from Lagovas as a code owner July 26, 2021 09:28
@julepka julepka requested a review from ilammy July 26, 2021 09:28
@julepka julepka merged commit e549eac into cossacklabs:release/0.13 Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vixentael vixentael vixentael approved these changes

@Lagovas Lagovas Awaiting requested review from Lagovas Lagovas is a code owner

@ilammy ilammy Awaiting requested review from ilammy

Assignees
No one assigned
Labels
M1 M-Carthage Package manager: Carthage, Objective-C and Swift, iOS and macOS M-CocoaPods Package manager: CocoaPods, Objective-C and Swift, iOS and macOS M-SPM Package manager: Swift Package Manager, Swift, iOS and macOS O-iOS 📱 Operating system: iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XCFramework missing ARM64 symbols for Simulator
2 participants
@julepka @vixentael