Use Ninja for BoringSSL if available #837
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ninja build tool significantly reduces compilation time for BoringSSL in default configuration.
This is mostly due to the fact that it performs parallel builds by default but there are other gains (Makefiles that CMake generates are not that optimal).
make -j4
is also a viable option, but it often ends up brittle.Timings for my machine
As you can see, there is some gain in wall clock time (real), resulting in shorter builds. However, this comes mostly from better parallelization if you look at the user time.
time make ENGINE=boringssl
master:
with ninja:
time emmake make wasmthemis
master:
with ninja:
Timings for GitHub Actions
It's always nice to see builds run a bit quicker.
master:
with ninja:
Checklist