Update zeroize to 1
#799
Merged
Update zeroize to 1
#799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the only dependency of RustThemis and they have managed to break even that. Some bright maintainer head over there thought that it would be a great idea to just yank all 0.x versions from crates.io, breaking our build. (Since RustThemis is a library, we're not using Cargo.lock. If a dependency is yanked, we can't build our stuff.) Well, thanks for not breaking the API in 1.x at least. You're still better than the Tokio team. Note that zeroize requires reasonably new stable version of Rust toolchain. With 0.5.2 this has been 1.31, now it's 1.47. (The current stable version is 1.51. RustThemis tracks that version.)
ilammy
added
W-RustThemis 🦀
vixentael
approved these changes
Apr 20, 2021
ilammy
added a commit
that referenced
this pull request
Apr 20, 2021
This is the only dependency of RustThemis and they have managed to break even that. Some bright maintainer head over there thought that it would be a great idea to just yank all 0.x versions from crates.io, breaking our build. (Since RustThemis is a library, we're not using Cargo.lock. If a dependency is yanked, we can't build our stuff.) Well, thanks for not breaking the API in 1.x at least. You're still better than the Tokio team. Note that zeroize requires reasonably new stable version of Rust toolchain. With 0.5.2 this has been 1.31, now it's 1.47. (The current stable version is 1.51. RustThemis tracks that version.) (cherry picked from commit 9b3fc01)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only dependency of RustThemis and they have managed to break even that 🤦
Some bright maintainer head over there thought that it would be a great idea to just yank all 0.x versions from crates.io, breaking our build. (Since RustThemis is a library, we're not using Cargo.lock. If a dependency is yanked, we can't build our stuff.)
Well, thanks for not breaking the API in 1.x at least. You're still better than the Tokio team.
Note that zeroize requires reasonably new stable version of Rust toolchain. With 0.5.2 this has been 1.31, now it's 1.47. (The current stable version is 1.51. RustThemis tracks that version.)
Checklist