Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update iOS/macOS examples to use Themis 0.13.4 #740

Merged
merged 6 commits into from
Oct 29, 2020
Merged

Update iOS/macOS examples to use Themis 0.13.4 #740

merged 6 commits into from
Oct 29, 2020

Conversation

vixentael
Copy link
Contributor

@vixentael vixentael commented Oct 29, 2020 •
edited
Loading

After glorious 0.13.4 release, let's update iOS and macOS examples for Carthage and CocoaPods to use Themis 0.13.4.

For iOS:

  • disabled ARM64-iphone simulator slice

For macOS:

  • enabled ARM64 slice

All changes were tested on device and via TestFlight.

Checklist

  • The [coding guidelines] are followed
  • Example projects and code samples are up-to-date (in case of API changes)
  • Changelog is updated (in case of notable or breaking changes)

ilammy
ilammy approved these changes Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@ilammy ilammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eagerly awaits for CI to complete its run...

CHANGELOG.md Outdated Show resolved Hide resolved
docs/examples/objc/macOS-Carthage/ThemisTest.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@vixentael
Copy link
Contributor Author

Everyone sees that it's green? Okok

@vixentael vixentael added docs 📚 Documentation, both offline and online M-Carthage Package manager: Carthage, Objective-C and Swift, iOS and macOS M-CocoaPods Package manager: CocoaPods, Objective-C and Swift, iOS and macOS O-iOS 📱 Operating system: iOS O-macOS 💻 Operating system: macOS labels Oct 29, 2020
@vixentael vixentael mentioned this pull request Oct 29, 2020
Closed
@vixentael vixentael merged commit d854c61 into master Oct 29, 2020
@vixentael vixentael deleted the vxtl/0.13.4-update-examples branch October 29, 2020 16:43
@ilammy ilammy mentioned this pull request Nov 4, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilammy ilammy ilammy approved these changes

@shadinua shadinua Awaiting requested review from shadinua

@julepka julepka Awaiting requested review from julepka julepka is a code owner

Assignees
No one assigned
Labels
docs 📚 Documentation, both offline and online M-Carthage Package manager: Carthage, Objective-C and Swift, iOS and macOS M-CocoaPods Package manager: CocoaPods, Objective-C and Swift, iOS and macOS O-iOS 📱 Operating system: iOS O-macOS 💻 Operating system: macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vixentael @ilammy