Update supported SDKs and archs for Carthage #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like we did for CocoaPods earlier, bump the minimum versions for Carthage to the defaults suggested by Xcode 12.
As noted before several times, it is not possible to distribute several arm64 slices in a single regular framework. It is possible with XCFrameworks, but we'll still need to do the migration. For now, keep arm64 disabled for iOS Simulator, disallowing its use with Apple Silicon. CLOpenSSL dependency does not provide this slice either. Disable arm64 for macOS as well because the current version of CLOpenSSL does not include support for Apple Silicon. macOS support will be enabled back with an update CLOpenSSL release, but iOS Simulator will have to wait until the XCFramework migration.
Since now arm64 is being disabled in Xcode project directly, no special tricks are needed to disable it in Carthage builds run by CI. However, the scripts provided for examples are kept in place for the benefit of the users. CI tests the latest version from master, but examples refer to 0.13.3 which still does not have arm64 exclusion.
ilammy
added
O-iOS 📱
vixentael
approved these changes
Oct 27, 2020
ilammy
added a commit
to ilammy/themis
that referenced
this pull request
Oct 28, 2020
* Bump iOS and macOS minimum SDK versions Just like we did for CocoaPods earlier, bump the minimum versions for Carthage to the defaults suggested by Xcode 12. * Exclude arm64 for iOS Simulator and macOS As noted before several times, it is not possible to distribute several arm64 slices in a single regular framework. It is possible with XCFrameworks, but we'll still need to do the migration. For now, keep arm64 disabled for iOS Simulator, disallowing its use with Apple Silicon. CLOpenSSL dependency does not provide this slice either. Disable arm64 for macOS as well because the current version of CLOpenSSL does not include support for Apple Silicon. macOS support will be enabled back with an update CLOpenSSL release, but iOS Simulator will have to wait until the XCFramework migration. (cherry picked from commit ca0b853) arm64 hacks are not removed from GitHub Actions since they were never added to the release/0.13 branch in the first place. Signed-off-by: Alexei Lozovsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several changes here, bringing Carthage in sync with CocoaPods.
Minimum SDK versions
Just like we did for CocoaPods earlier, bump the minimum SDK versions for Carthage to the defaults suggested by Xcode 12.
arm64 exceptions
As noted before several times, it is not possible to distribute several arm64 slices in a single regular framework. It is possible with XCFrameworks, but we'll still need to do the migration.
For now, keep arm64 disabled for iOS Simulator, disallowing its use with Apple Silicon. CLOpenSSL dependency does not provide this slice either.
Disable arm64 for macOS as well because the current version of CLOpenSSL does not include support for Apple Silicon.
macOS support will be enabled back with an update CLOpenSSL release, but iOS Simulator will have to wait until the XCFramework migration.
CI updates
Since now arm64 is being disabled in Xcode project directly, no special tricks are needed to disable it in Carthage builds run by CI.
However, the scripts provided for examples are kept in place for the benefit of the users. CI tests the latest version from master, but examples refer to 0.13.3 which still does not have arm64 exclusion.
Checklist
Example projects and code samples are up-to-date(unchanged)Required reviews: