Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ios objc and server examples for themis 0.13.3 #723

Merged

Conversation

julepka
Copy link
Contributor

@julepka julepka commented Oct 13, 2020

Updated iOS Objective-C and Themis-server examples for Themis 0.13.3. Resolved Xcode warnings.

Checklist

  • Change is covered by automated tests
  • Example projects and code samples are up-to-date (in case of API changes)
  • Changelog is updated (in case of notable or breaking changes)

@julepka julepka added O-iOS 📱 Operating system: iOS M-CocoaPods Package manager: CocoaPods, Objective-C and Swift, iOS and macOS labels Oct 13, 2020
@@ -20,7 +20,7 @@ _Code:_
- **Objective-C**

- Switched to test on Xcode 12.0, disable ARM64 builds for Themis CocoaPods and Themis Carthage ([#721](https://github.com/cossacklabs/themis/pull/721), [#722](https://github.com/cossacklabs/themis/pull/722)).
- Updated Objective-C examples (iOS and macOS, Carthage and CocoaPods) to showcase usage of the newest Secure Cell API: generating symmetric keys and using Secure Cell with Passphrase ([#688](https://github.com/cossacklabs/themis/pull/688)) and to use latest Themis 0.13.2, 0.13.3 ([#701](https://github.com/cossacklabs/themis/pull/701), [#703](https://github.com/cossacklabs/themis/pull/703), [#706](https://github.com/cossacklabs/themis/pull/706)).
- Updated Objective-C examples (iOS and macOS, Carthage and CocoaPods) to showcase usage of the newest Secure Cell API: generating symmetric keys and using Secure Cell with Passphrase ([#688](https://github.com/cossacklabs/themis/pull/688)) and to use latest Themis 0.13.2, 0.13.3 ([#701](https://github.com/cossacklabs/themis/pull/701), [#703](https://github.com/cossacklabs/themis/pull/703), [#706](https://github.com/cossacklabs/themis/pull/706), [#723](https://github.com/cossacklabs/themis/pull/723)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the same for Swift item below

@julepka julepka marked this pull request as ready for review October 13, 2020 14:48
Copy link
Collaborator

@ilammy ilammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes (useless) test targets from example projects. Demo projects are intended to be run on devices directly. We have a dedicated project with unit tests.

Also, Swift examples are compiled with Swift 5 now, yay! 🎉

Count me in 👍

@julepka julepka merged commit dc336bb into cossacklabs:master Oct 13, 2020
ilammy pushed a commit to ilammy/themis that referenced this pull request Oct 26, 2020
* update ios objc and server examples for themis 0.13.3

* updated changelog

(cherry picked from commit dc336bb)
ilammy added a commit to ilammy/themis that referenced this pull request Oct 26, 2020
…cossacklabs#724, cossacklabs#726)

* Switch github actions to Xcode12 [ios, macos] (cossacklabs#721)
  - update github actions xcode12
  - update changelog
  - update swift ios cocoapods project
  (cherry picked from commit d22bbab)

* Updates of example projects for Xcode12.0.1 (cossacklabs#722)
  - github actions -> use xcode 12.0
  - updating ios swift cocoapods example for themis 0.13.3
  - disable openssl-1.1.1 subspec
  - "fix" carthage build by disabling arm64
  - github actions: carthage, exclude arm64 architecture
  - update changelog
  (cherry picked from commit 1ae32a3)

* update ios objc and server examples for themis 0.13.3 (cossacklabs#723)
  - update ios objc and server examples for themis 0.13.3
  - updated changelog
  (cherry picked from commit dc336bb)

* update iOS carthage examples for themis 0.13.3 (cossacklabs#724)
  - update iOS carthage examples for themis 0.13.3
  - updated changelog
  (cherry picked from commit 0577424)

* updated macOS examples for themis 0.13.3 (cossacklabs#726)
  - updated macOS examples for themis 0.13.3
  - updated changelog
  (cherry picked from commit 9f14a5e)

I've squashed all commits in one as conceptually this is a single change
migrating the build to Xcode 12 and examples to Themis 0.13.3 which
supports Xcode 12.

The changes do not include CHANGELOG.md, but that will be synced later
during the next major release.

Signed-off-by: Alexei Lozovsky <[email protected]>
Co-authored-by: julepka <[email protected]>
Co-authored-by: vixentael <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-CocoaPods Package manager: CocoaPods, Objective-C and Swift, iOS and macOS O-iOS 📱 Operating system: iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants