Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dynamically generated errors with constants #711

Merged
merged 8 commits into from
Sep 5, 2020
Merged

Replace dynamically generated errors with constants #711

merged 8 commits into from
Sep 5, 2020

Commits on Sep 1, 2020

  1. Replace dymanically generated errors with const ones 

    Only errors that contain static text message were replaced.
    @iamnotacake
    iamnotacake committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    1cf684b View commit details
    Browse the repository at this point in the history

  2. Replace dymanically generated callback errors with const ones 

    Replace errors created with `errors.NewCallbackError()`.
    @iamnotacake
    iamnotacake committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    de4f0d0 View commit details
    Browse the repository at this point in the history

  3. Updates after review 

    Give errors more verbose names
    @iamnotacake
    iamnotacake committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    bec889d View commit details
    Browse the repository at this point in the history

  4. Rename ErrOverflow -> ErrOutOfMemory

    @iamnotacake
    iamnotacake committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    2505434 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Updates after review 

    * Update changelog
* Deprecate ErrOverflow, use ErrOutOfMemory instead
* Rename many errors, remove redundant ones
    @iamnotacake
    iamnotacake committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    f204717 View commit details
    Browse the repository at this point in the history

  2. Unify few session errors into ErrMessageSize and ErrMessageData 

    * Replace ErrGetRequestSize, ErrGetWrappedSize, ErrGetUnwrappedSize
  with ErrMessageSize
* Replace ErrGenerateRequest, ErrWrapData, ErrUnwrapData
  with ErrMessageData
    @iamnotacake
    iamnotacake committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    89d2876 View commit details
    Browse the repository at this point in the history

  3. Fix typo in changelog, change deprecation version

    @iamnotacake
    iamnotacake committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    f4f0857 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Make error messages start with lowercase

    @iamnotacake
    iamnotacake committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    2e5a258 View commit details
    Browse the repository at this point in the history