Start phasing out CircleCI #709
Conversation
Remove jobs that have been completely replaced by GitHub Actions.
- "android" replaced with "android-tests" from "test-java.yaml".
- "analyze" replaced with "check-formatting" from "code-style.yaml"
and "sanitizers" from "test-core.yaml".
- "benchmark" replaced with "benchmarks" from "test-core.yaml".
- "fuzz" replaced with "fuzzing" from "test-core.yaml".
- "gothemis" replaced with "unit-tests" from "test-go.yaml".
- "jsthemis" replaced with "unit-tests" from "test-{nodejs,wasm}.yaml".
- "integration_tests" replaced with "cross-language" from "integration.yaml".
- "php5", "php70", "php71" replaced with "unit-tests" from "test-php.yaml".
Drop tasks from the "x86_64" megajob which have been replaced by
individual jobs on GitHub Actions.
- ThemisPP is tested by "unit-tests" in "test-cpp.yaml".
- JNI library tested by "unit-tests" in "test-java.yaml".
- PyThemis is tested by "unit-tests" in "test-python.yaml".
- RbThemis is tested by "unit-testt" in "test-ruby.yaml". There is no need
to install RVM if this gets removed.
- RustThemis is tested by "unit-tests" in "test-rust.yaml". There is no
need to install Rust toolachain too.
- Builds with Valgrind are tested by "leak-check" in "test-core.yaml".
- Themis Core (include Secure Cell compatibility) is tested by
"unit-tests" in "test-core.yaml".
There is no need to install so many packages either. However, some of
them are still necessary to build Themis Core for coverage testing.
There was a problem hiding this comment.
Seems like CircleCI will have much less work to do.
This PR removes the parts of CircleCI configuration which are already replaced with GitHub Actions
So even Android was already tested by GHA? Didn't notice that before. Well, maybe because GHA skips testing my non-Android-related changes on Themis.
And I see you cleaned x86_64 -> docker -> cossacklabs/android-build:2019.01 so it's only doing code coverage tests now?
Yes, unless you touch anything that can affect Android builds, those builds are not started. For example, note how here you have Android emulator runs because Themis Core is changed, but if only Rust core is changed then Android tests are not triggered. Additionally, regardless of the changeset, full test suite is run after any PR is merged into master or any of the release branches.
That's right. This is the only thing it does now. |
|
Let's see how it goes. |
|
Also, we might need to update "branch protection rules" settings to mark some GHA jobs as required. |
Yeah, good idea! Though, GHA badges are a bit different since their suite is split into multiple "workflows" and badges are per-workflow. So guess the best way would be to put integration testing badge up top:
Since this workflow is the closest one to testing everything at once. Or we can use the Core one:
And maybe add per-languages badges down in the language table:
What do you think?
Here we need to be careful to not shoot ourselves into the foot. See how this PR requires some CircleCI jobs to pass which will never complete? I don't want documentation PRs to be blocked if they don't trigger any GHA jobs... |
|
@ilammy great suggestions! Let's use maximum :) Let's put And then language-dependent badges to the language table.
Exactly.. Looks like we already need to fix branch protection rules. |
Since we're switching to GitHub Actions as a primary indicator of CI health, add some badges for them. Since there is no single omnibadge for the entire test suite, add multiple one for various aspects. Since there are many badges there, they don't really fit in line. Move them all into the second row.
I tried fitting them in, but the horizontal space must be very expensive there. However I try to jam them into that table, they just don't look pretty. So maybe we don't need them. Even badges for GHA take a bunch of space so I had to move them to the second line so that it looks nicer. |
|
Totally ok not having language badges.
…On Mon, 17 Aug 2020 at 21:21, Alexei Lozovsky ***@***.***> wrote:
And then language-dependent badges to the language table.
I tried fitting them in, but the horizontal space must be very expensive
there. However I try to jam them into that table, they just don't look
pretty. So maybe we don't need them.
Even badges for GHA take a bunch of space so I had to move them to the
second line so that it looks nicer.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#709 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAV6TYEPH5M66QV2PUOV7ETSBFYJTANCNFSM4QBUJGPA>
.
|
|
Well, as for required checks, I don't have a good solution at the moment. For now, I have lifted the requirement from most of them. There is an internal task tracking this issue: T1759. I hope some day GHA checks can be made required. |
GitHub Actions, first introduced in March (#600), has been more or less stable alternative to CircleCI. In fact, by observations show that both GHA and CircleCI have about the same rate of spurious failures (around 15 broken builds per month, due to various reasons).
Most of the jobs performed by CircleCI are duplicated on GitHub Actions. However, CircleCI has subpar capabilities of limiting the build impact. Currently, every changeset triggers the entire CircleCI build which takes ages (~30–40 minutes). CircleCI does not have built-in support for triggering builds only on some files, as opposed to GitHub Actions.
Given this, I suggest to phase out CircleCI in favor of GitHub Actions, arguably better integrated with GitHub. This PR removes the parts of CircleCI configuration which are already replaced with GitHub Actions. Eventually, the remaining bits will be migrated to GitHub Actions too and CircleCI configuration can be removed completely.
Checklist