Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iOS and macOS examples to use Themis 0.13.1 and OpenSSL 1.1.1g #701

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

vixentael
Copy link
Contributor

Updated iOS and macOS examples to use Themis 0.13.1 and OpenSSL 1.1.1g.

Checklist

  • [] Change is covered by automated tests
  • [] Benchmark results are attached (if applicable)
  • The coding guidelines are followed
  • [] Public API has proper documentation
  • Example projects and code samples are up-to-date (in case of API changes)
  • Changelog is updated (in case of notable or breaking changes)

@vixentael vixentael requested a review from ilammy August 13, 2020 18:05
@vixentael vixentael added docs 📚 Documentation, both offline and online M-Carthage Package manager: Carthage, Objective-C and Swift, iOS and macOS M-CocoaPods Package manager: CocoaPods, Objective-C and Swift, iOS and macOS O-iOS 📱 Operating system: iOS O-macOS 💻 Operating system: macOS labels Aug 13, 2020
@ilammy ilammy changed the title updated iOS and macOS examples to use themis 0.13.1 and openssl 1.1.1g Updat iOS and macOS examples to use Themis 0.13.1 and OpenSSL 1.1.1g Aug 13, 2020
@ilammy ilammy changed the title Updat iOS and macOS examples to use Themis 0.13.1 and OpenSSL 1.1.1g Update iOS and macOS examples to use Themis 0.13.1 and OpenSSL 1.1.1g Aug 13, 2020
Copy link
Collaborator

@ilammy ilammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tedious but necessary. Thanks.

PRODUCT_BUNDLE_IDENTIFIER = com.stanfy.WorkingWithThemisServer;
PRODUCT_BUNDLE_IDENTIFIER = com.cl.WorkingWithThemisServer;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well had spelled the full domain name, IMO: com.cossacklabs.<...>

@vixentael vixentael merged commit 28c8f83 into master Aug 14, 2020
@vixentael vixentael deleted the vxxtl/update-examples-for-themis branch August 14, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs 📚 Documentation, both offline and online M-Carthage Package manager: Carthage, Objective-C and Swift, iOS and macOS M-CocoaPods Package manager: CocoaPods, Objective-C and Swift, iOS and macOS O-iOS 📱 Operating system: iOS O-macOS 💻 Operating system: macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants