Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NodeJS SecureSession handling nullptr #698

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Fix NodeJS SecureSession handling nullptr #698

merged 2 commits into from
Aug 13, 2020

Commits on Aug 13, 2020

  1. Fix NodeJS SecureSession handling nullptr 

    Checking whether passed key is a private key is not enough since not all
private keys are supported. For example, `secure_session_create()` may
return NULL for RSA key. In this case, we get no exception on JS side
but as soon as we try to connect to other peer (or accept connection)
using created object, we get error. This commit makes sure we throw JS
exception in case `secure_session_create()` returns NULL.
    @iamnotacake
    iamnotacake committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    dc261c9 View commit details
    Browse the repository at this point in the history

  2. Update after review 

    Make `isCreated()` a private method
    @iamnotacake
    iamnotacake committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    15d5a3e View commit details
    Browse the repository at this point in the history