Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop libthemis-src support #691

Merged
merged 3 commits into from
Aug 6, 2020
Merged

Drop libthemis-src support #691

merged 3 commits into from
Aug 6, 2020

Commits on Aug 6, 2020

  1. Drop libthemis-src support 

    RustThemis has a `libthemis-src` crate which can be enabled with
`vendored` feature. It will build Themis library on-the-fly, during
`themis` build. It was a nice idea in the beginning, aimed at making
developers' lives easier. However, it also has some issues and
maintenance overhead:
* This is yet another configuration. There are tests for it, but they
  don't cover actual `themis` execution in this configuration, only
  `libthemis-src` build itself.
* Those tests may cause false positives because they are run from the
  repository root. In fact, currently published `libthemis-src = 0.13.0`
  does not build because some files are missing from it.
* We hijack a lot of decisions from the developers: how to link against
  Themis and what cryptography backend to use. `libthemis-src` does not
  offer a choice of the backend, it's always system OpenSSL.
* Building `libthemis-src` requires a tricky repository layout with
  symlinks that point to Themis source code. Every time a new build
  dependency is added, maintainers need to make sure that all
  dependencies are symlinked.
* `cargo publish` does not handle symlinks well and it may break
  publishing at times, when symlinks are included into the crate, not
  the files they point to.
    @iamnotacake
    iamnotacake committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    e1ffd83 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md; don't search for libthemis when generating docs 

    * Rewrite description of changes in changelog
* Don't search for Themis libs if env var DOCS_RS is 1
  (it is set to 1 when docs are generated for https://docs.rs website)
    @iamnotacake
    iamnotacake committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    4bddd3f View commit details
    Browse the repository at this point in the history

  3. Remove unneeded deps in Cargo.toml (themis and libthemis-sys)

    @iamnotacake
    iamnotacake committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    7aa61b1 View commit details
    Browse the repository at this point in the history